Wrong MySQL declarations
Bug #498068 reported by
Peter
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Jisko |
Fix Released
|
Medium
|
Marcos Garcia | ||
Bug Description
This is regarding private notes and received Twitter notes.
You declared in DB->notes column read as TINYINT(1) , but when inserting information you use "false" or "true". In strict MySQL (above 5.0.2) that doesn't work and will not insert a thing.
Since you are not checking that you actually get something back after the query the script is continuing as if it was inserted.
Changing the read column to VARCHAR(30) to check and then it is working.
(Overall I found several of these, but most of them was before the declaration was NOT NULL, but should accept NULL. I think all database declarations should be looked over together with INSERT statements.)
Revision history for this message
| Marcos Garcia (marcosgdf) wrote | #1 |
| Changed in jisko: | |
| importance: | Undecided → Medium |
| milestone: | none → v2 |
| Changed in jisko: | |
| status: | New → Confirmed |
| status: | Confirmed → In Progress |
| assignee: | nobody → Marcos Garcia (marcosgdf) |
Revision history for this message
| Marcos Garcia (marcosgdf) wrote | #2 |
| Changed in jisko: | |
| status: | In Progress → Fix Committed |
| Changed in jisko: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Will check it.