Launchpad itself

Launchpad loads system plugins into its eggified bzr

Bug #497731 reported by Max Bowsher
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Max Bowsher
Launchpad itself 10.02

Bug Description

Bug 316192 seems to have regressed.

I was running tests on db-devel r8806 i.e. 3.1.12 rollout, which uses bzr 2.1b3. I got two failures in lp.codehosting.tests.test_lpserve.TestLaunchpadServe, caused by bzr 2.1b3 loading bzr-gtk and bzr-rebase that I had installed as .debs (on karmic) and failing the version compatibility check.

Tags: lp-code

Related branches

lp:~maxb/launchpad/bug-497731
Guilherme Salgado (community): Approve (code)
Diff: 151 lines (+26/-40)
4 files modified
lib/lp/codehosting/__init__.py (+16/-4)
lib/lp/codehosting/sshserver/tests/test_session.py (+2/-2)
lib/lp/codehosting/tests/test_acceptance.py (+5/-3)
lib/lp/codehosting/tests/test_lpserve.py (+3/-31)
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I can't reproduce this :/

Changed in launchpad-code:
status: New → Incomplete
Revision history for this message
Max Bowsher (maxb) wrote :

Still a problem for me in a fresh test run of devel a few hours ago. I guess I'll have to dig into it myself a bit.

Revision history for this message
Max Bowsher (maxb) wrote :

I've no idea why mwhudson can't reproduce it, but I've figured out what's happening.

When you import bzrlib from within lp.codehosting, it calls load_plugins with a fixed path list, and all is well. BUT when you shell out to bzr lp-serve, merely setting BZR_PLUGIN_PATH=.../bzrplugins is insufficient to avoid importing from the 'site' directory... i.e. /usr/lib/python2.6/dist-packages/bzrlib/plugins/

The proper fix is to include -site in BZR_PLUGIN_PATH to turn this off.

Changed in launchpad-code:
assignee: nobody → Max Bowsher (maxb)
status: Incomplete → In Progress
Michael Hudson-Doyle (mwhudson)
Changed in launchpad-code:
milestone: none → 10.02
Tim Penhey (thumper)
Changed in launchpad-code:
importance: Undecided → Medium
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

launchpad/devel r10358

Changed in launchpad-code:
status: In Progress → Fix Committed
Tim Penhey (thumper)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.