KeyError in checkwatches cause the script to abort
Bug #496988 reported by
Graham Binns
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Graham Binns |
Bug Description
What happens:
See OOPS-1444CCW1146. If a KeyError is raised in a checkwatches run, even if it's relatively harmless, the script will abort. If it happens repeatedly then a given bugtracker will never get updated.
What should happen:
KeyErrors should be handled quietly and logged, if anything. The script shouldn't blow up.
Related branches
lp:~gmb/launchpad/checkwatches-keyerror-oops-bug-496988
Merged
into
lp:launchpad
- Данило Шеган (community): Approve (release-critical)
- Brad Crittenden (community): Approve (code)
-
Diff: 116 lines (+100/-1)2 files modifiedlib/lp/bugs/scripts/checkwatches.py (+1/-1)
lib/lp/bugs/scripts/tests/test_checkwatches.py (+99/-0)
tags: | added: current-rollout-blocker |
Changed in malone: | |
assignee: | nobody → Graham Binns (gmb) |
Changed in malone: | |
status: | Triaged → In Progress |
Changed in malone: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in db r8801 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ db-devel/ revision/ 8801>