`bzr unshelve --delete` should say that changes deleted
Bug #496917 reported by
Alexander Belchenko
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
Neil Martinsen-Burrell |
Bug Description
$ bzr unshelve --delete
Unshelving changes with id "1".
The message is misleading, especially for non-native english people. Moreover the same message shown even when changes actually unshelved, again it's misleading.
Related branches
lp:~nmb/bzr/fix-496917
- Martin Pool: Approve
- Alexander Belchenko: Approve
-
Diff: 109 lines (+51/-1)3 files modifiedNEWS (+6/-0)
bzrlib/shelf_ui.py (+2/-1)
bzrlib/tests/test_shelf_ui.py (+43/-0)
Changed in bzr: | |
assignee: | nobody → Neil Martinsen-Burrell (nmb) |
milestone: | none → 2.1.0rc1 |
status: | Confirmed → Fix Released |
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Alexander Belchenko wrote:
> Public bug reported:
>
> $ bzr unshelve --delete
> Unshelving changes with id "1".
>
> The message is misleading, especially for non-native english people.
> Moreover the same message shown even when changes actually unshelved,
> again it's misleading.
>
> ** Affects: bzr
> Importance: Undecided
> Status: New
>
importance medium
status confirmed
tags easy doc
I may be wrong about 'easy' as it may be difficult to change the text.
But certainly changing it from: Unshelved changes with id "1"
to something like: Deleted changes with id "1".
Would be reasonable.
Of course, it *did* take the changes off the shelf. We just don't
specify whether those were applied to the wt or not. :)
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org/
npXwACgkQJdeBCY SNAANyOwCeMqK4u x6itKJds1nhX4SI ycEq 1sW5z0RZ6eBZxA0 F0
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAks
Zd8An1roAXqzXOV
=c7ZK
-----END PGP SIGNATURE-----