Document client provided tags feature in the client manpage

[Andreas Hasenack]

The landscape-client manpage (and/or landscape-config) should mention the new tag command line option.

[Andreas Hasenack (ahasenack)]

I also took the liberty of updating the other manpages.

For review, it's easier to review the changes in the .txt files

[Kevin McDermott (bigkevmcd)]

+ -k SSL_PUBLIC_KEY, --ssl-public-key=SSL_PUBLIC_KEY The public SSL key to
+ verify the server. Only used if the given URL is
+ https.

This is actually the certificate, not the public key (it's a really badly named option), and "the given URL" which one?

We don't support non-HTTPS connections to Landscape, so providing a non-HTTPS transport URL to the client won't work.

+ --cloud Set this if your computer is in an EC2 cloud.

I'd be concerned that there's more to this than just adding --cloud to the configuration script.

Kevin

[Jamu Kakar (jkakar)]

[1]

+OPTIONS
+ --version show program's version number and exit
+ -h, --help show this help message and exit

'show' in the descript should be 'Show'. Also, I don't know if it
matters, but there's trailing whitespace in some of the .txt files.

[2]

I wonder if we should include the default values in option
descriptions?

Thanks for cleaning this up, +1!

[Andreas Hasenack (ahasenack)]

Kevin:

[1]

Done. I also looked into renaming that option to --ssl-ca-certificate instead of --ssl-public-key, but that implies in code changes in a lot of places, and there is also an upgrade path to consider. If we think it's worth it, I can give it a try in another ticket, probably making both options work as synonyms but marking the --ssl-public-key one as deprecated.

[2]

done

Jamu:

[1]

Done

[2]

Done, I added defaults to the help text and manpages. Maybe even to some options we don't really want people messing with, as Kevin mentioned in IRC.

Please re-review

[Jamu Kakar (jkakar)]

The ongoing review comments are here:

https://code.edge.launchpad.net/~ahasenack/landscape-client/496626-manpage-tags/+merge/17599

[Andreas Hasenack (ahasenack)]

Tested with staging packages.