Focus descCtrl after successful creation of new transaction

Bug #496342 reported by arty
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
wxBanker
Fix Released
Low
Michael Rooney

Bug Description

When I enter multiple today's transactions it is convenient to have descCtrl focused. Now it happens like this:

1) enter description
2) enter amount
3) press enter (amount control remains focused)
4) press shift+tab
5) repeat

I want to exclude step 4 to make it look like:

1) enter description
2) enter amount
3) press enter (focus goes to description field)
5) repeat

I just edited newtransactionctrl.py and added to method `clear` this line:

self.descCtrl.SetFocus()

Related branches

Revision history for this message
Michael Rooney (mrooney) wrote :

This sounds like good behavior indeed, thanks for giving me the exact line to implement it :)

I will implement this in the next point release. Any other suggestions, ideas, or problems (besides the nasty upgrade issue)?

Changed in wxbanker:
assignee: nobody → Michael Rooney (mrooney)
importance: Undecided → Low
milestone: none → future
status: New → Triaged
milestone: future → 0.6.1
Revision history for this message
arty (me-arty) wrote :

Well, having a default account (or at least making active the one which was active on last shutdown) would be a nice touch. I've already suffered of few mistargeted transations, which I had to move manually to another account because installed version had no support for moving them.

Another thing is somewhat controversial, but I suppose there're more spendings than earnings, so having '-' by default in account could be convenient.

I'm not sure about reproducibility of that issue, but in my case 'amount' and 'total' columns by default get too narrow and show ellipsis in most rows. Maybe that's because of long currency name (I use RUB: руб).

Icons are nice, but 'Clear search transactions' icon is inconsistent with others.

Generally main window could be made slicker by following i.e. Gnome HIG (or just by adding some paddings to elements and better aligning them along the grid). But I say that because I like looks of most Gnome apps.

And tabs… I'm not sure it's possible to achieve that with wx, but in Gnome they do not have native look and feel, i.e. do not switch with alt+1, alt+2.

But anyway I'm very thankful for creating the only finance management application I can use : )

Revision history for this message
Michael Rooney (mrooney) wrote :

I'll get 0.6.1 out the door to fix the bug, and do this in the next point release.

Changed in wxbanker:
milestone: 0.6.1 → future
Revision history for this message
Michael Rooney (mrooney) wrote :

Okay, I committed your focus patch to trunk. If you want to file bugs for the other issues mentioned that would be great, otherwise I will hopefully get to it tomorrow myself. I would definitely like to have it remember the last account that was selected as well! And I agree with the other issues. If you are able to take a screenshot and point out (even very sloppily) which areas could be improved via padding / alignment, I will happily fix that as well.

Thanks again for your bug reports, feedback, and suggestions, they are all quite valuable!

Revision history for this message
Michael Rooney (mrooney) wrote :

Okay, the column width issue you mentioned is the existing bug #324435, so feel free to subscribe to that one.

Then I filed:
  * bug #496874 for the search icon
  * bug #496876 for remember last account
  * bug #496878 for the padding / HIG issues you mentioned. I've marked this one Incomplete and assigned to you :) so that you can provide feedback in that bug about which specific changes would be good to make. Feel free to make a bzr branch (https://answers.launchpad.net/wxbanker/+faq/214) or send a patch my way, or if you just want to provide the input that's fine and I can then implement your suggestions and take assignment of the bug.

I'd recommend subscribing to those bugs then. Thanks again for your feedback, I've scheduled the 3 new bugs for the next release, but I won't be able to implement the HIG one without your feedback so I'm looking forward to any help there. Thanks again!

Revision history for this message
Michael Rooney (mrooney) wrote :

Okay, now that there are separate bugs for the other issues (feel free to file more for other ones!), this specific one can be marked as Fix Committed in trunk!

Changed in wxbanker:
milestone: future → 0.7
status: Triaged → Fix Committed
Revision history for this message
Michael Rooney (mrooney) wrote :

I'm thinking maybe it should be focused on more events as well. For example, it should be focused by default when starting wxBanker and when selecting an account. The only downside of this is that when focused, the description control loses its "hint" where it says "Description" in gray.

Any thoughts on that?

Changed in wxbanker:
status: Fix Committed → Incomplete
summary: - Focus descCtrl after successfull creation of new transaction
+ Focus descCtrl after successful creation of new transaction
Revision history for this message
Michael Rooney (mrooney) wrote :

It seems good to me thus far so I'll re-close it, but if you have any input it would certainly be appreciated.

Changed in wxbanker:
status: Incomplete → Fix Committed
Revision history for this message
arty (me-arty) wrote :

Concerning focus on app start: I think it shouldn't be focused at that moment, but be the first in tab order. That way after you've started wxBanker, you only press tab once, and you're ready to enter new transaction.

Michael Rooney (mrooney)
Changed in wxbanker:
status: Fix Committed → In Progress
Revision history for this message
Michael Rooney (mrooney) wrote :

I like that idea, and I think it will fix a bug I am having now also. I shall do that.

Revision history for this message
Michael Rooney (mrooney) wrote :

Changing to Triaged, as this bug is impeded until the other bug is fixed that will allow tabbing out of the date control.

Changed in wxbanker:
status: In Progress → Triaged
Revision history for this message
Michael Rooney (mrooney) wrote :

Okay, all set! The date control has initial focus on startup, so a tab gets you to the description. When choosing an account manually afterwards or after entering a transaction, you end up in the description control. Sound good?

Changed in wxbanker:
status: Triaged → Fix Committed
Revision history for this message
arty (me-arty) wrote :

Yeah, sounds good

Michael Rooney (mrooney)
Changed in wxbanker:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.