Replying to review comments is broken
Bug #496340 reported by
Tim Penhey
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Tim Penhey |
Bug Description
I think I broke this when landing the form layout changes.
Related branches
lp:~thumper/launchpad/fix-windmill-reply-test
Merged
into
lp:launchpad
- Данило Шеган (community): Approve (release-critical)
- Michael Hudson-Doyle: Approve
-
Diff: 12 lines (+1/-1)1 file modifiedlib/canonical/launchpad/javascript/lp/comment.js (+1/-1)
summary: |
- Windmill test TestMergeProposalCommenting.test_merge_proposal_replying - failing + Replying to review comments is broken |
tags: | added: current-rollout-blocker |
Changed in launchpad-code: | |
status: | In Progress → Fix Committed |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Failure in test lp.code. windmill. tests.test_ merge_proposal_ commenting. TestMergePropos alCommenting. test_merge_ proposal_ replying slaves/ launchpad/ jscheck/ build/lib/ lp/testing/ __init_ _.py", line 450, in run slaves/ launchpad/ jscheck/ build/lib/ lp/code/ windmill/ tests/test_ merge_proposal_ commenting. py", line 67, in test_merge_ proposal_ replying asserts. assertValue( id="field. comment" , validator="> content") slaves/ launchpad/ jscheck/ build/orig_ sourcecode/ eggs/windmill- 1.3beta3_ lp_r1440- py2.5.egg/ windmill/ authoring/ __init_ _.py", line 161, in __call__ method( self.action_ name, **kwargs) slaves/ launchpad/ jscheck/ build/orig_ sourcecode/ eggs/windmill- 1.3beta3_ lp_r1440- py2.5.egg/ windmill/ authoring/ __init_ _.py", line 214, in _exec_test entException( result[ 'result' ]) entException: {'suite_name': 'Code review commenting', 'result': False, 'starttime': '2009-11- 13T19:18: 3.194Z' , 'params': {'validator': '> content', 'id': 'field.comment'}, 'debug': 'Found value "" is not equal to "> content"', 'output': None, 'endtime': '2009-11- 13T19:18: 3.195Z' , 'method': 'asserts. assertValue' }
Traceback (most recent call last):
File "/srv/buildbot/
testMethod()
File "/srv/buildbot/
client.
File "/srv/buildbot/
return self.exec_
File "/srv/buildbot/
raise WindmillTestCli
WindmillTestCli