Add Ubuntu Netbook Edition session

Bug #496301 reported by Didier Roche-Tolomelli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
maximus (Ubuntu)
Fix Released
Wishlist
Loïc Minier
netbook-launcher (Ubuntu)
Fix Released
Wishlist
Loïc Minier
ubuntu-netbook-remix-default-settings (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: ubuntu-netbook-remix-default-settings

ubuntu-netbook-remix-default-settings (0.6.8) lucid; urgency=low

  * shape une session and enable ubuntu GNOME installation on the same
    system:
    - add une.mandatory.path to include the new une session mandatory path
      in gconf
    - rename debian/gconf.default to debian/20_une-gconf-mandatory to
      avoid dh_gconf taking it into account
    - add une.desktop (use no more gnome.desktop file)
    - add those three previous files to debian/install
    - remove dh_gconf specific call in debian/rules
    - add debian/{postinst;postrm}:
      + register and remove gconf une mandatory value in non standard path
      + call gdm-set-default-session to add une as default session only if
        no other previous default session and remove if default

--------------------------
maximus (0.4.14-0ubuntu3) lucid; urgency=low

  * debian/rules: move autostart .desktop file to etc/xdg/xdg-une/
    (start only on une session) (LP: #496301)
  * debian/{pre,post}inst: handle conffile move

--------------------------

netbook-launcher (2.1.12-0ubuntu4) lucid; urgency=low

  * debian/netbook-launcher.install: install autostart desktop file in
    etc/xdg/xdg-une/autostart for launching in une session only
  * debian/{pre,post}inst: handle conffile move

Changed in ubuntu-netbook-remix-default-settings (Ubuntu):
status: New → Triaged
importance: Undecided → Wishlist
Changed in maximus (Ubuntu):
status: New → Triaged
importance: Undecided → Wishlist
description: updated
Changed in netbook-launcher (Ubuntu):
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :
Revision history for this message
Martin Pitt (pitti) wrote :

maximus, netbook-launcher: These need a preinst/postinst snippet to move the conffile on upgrades, too. Please see http://www.dpkg.org/dpkg/ConffileHandling for the standard recipe.

Is it possible to install them under /usr/share instead of /etc? Conffiles are quite a pain for reasons like the above.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-netbook-remix-default-settings - 0.6.8

---------------
ubuntu-netbook-remix-default-settings (0.6.8) lucid; urgency=low

  * shape une session and enable ubuntu GNOME installation on the same
    system: (LP: #496301)
    - add une.mandatory.path to include the new une session mandatory path
      in gconf
    - rename debian/gconf.default to debian/20_une-gconf-mandatory to
      avoid dh_gconf taking it into account
    - add une.desktop (use no more gnome.desktop file)
    - add those three previous files to debian/install
    - remove dh_gconf specific call in debian/rules
    - add debian/{postinst;postrm}:
      + register and remove gconf une mandatory value in non standard path
      + call gdm-set-default-session to add une as default session only if
        no other previous default session and remove if default
 -- Didier Roche <email address hidden> Sun, 13 Dec 2009 21:56:50 +0100

Changed in ubuntu-netbook-remix-default-settings (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

ok, I'm adding the code this evening for the conffile move. Sorry for haven fogotten that.

Considering moving them to /usr/share:
Even though I agree that those files shouldn't be conffile as users won't normally tweak them, I don't think we should make two cases: one for "common session autostart" in /etc/xdg/autostart and the other, session-depending in /usr/share/xdg... At least not now.
So, I just propose to keep them in /etc/xdg/xdg-session/autostart (to not add another different rule from thoses in /etc/xdg/autostart).

I've some ideas on lucid+1 for better session management and starting application, we can maybe discuss again about that at next UDS.

Revision history for this message
Loïc Minier (lool) wrote :
Revision history for this message
Loïc Minier (lool) wrote :

Please re-sub sponsors when there's a new .debdiff for the conffile moving changes, thanks!

description: updated
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :
Revision history for this message
Loïc Minier (lool) wrote :

There's a missing ";;" in case statements, i.e. instead of:
case
  a|b)
    foo
esac

one needs to write:
case
  a|b)
    foo
  ;;
esac

Couple of questions regarding the conffile moving bits:
* does it make sense to test for the version one upgrades to, or is it certain that /etc/xdg/autostart/netbook-launcher.desktop will never be an use case again? IOW, does it make sense for people to create this file themselves, or not?
* if the md5sum indicates the file has been modified, should you move the file to another place as a backup (without removing it, but effectively disabling it), or do you want to keep the two autostart files present (and hence enabled)?

(Is this otherwise ready to be sponsored? Not sure, you didn't resub the sponsors, wouldn't want to upload something which you might not consider ready)

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks Loïc to have a look at those two patches.

IIRC in posix, ";;" is not compulsory if you have only one case (it's just "stopping the current case before the next one). Furthermore http://wiki.debian.org/DpkgConffileHandling doesn't use it.
If you wish, I still can add it, just tell me.

Regarding your questions:
- after discussing yesterday with pitti about it, it's obvious that those files aren't really conffiles. It made little sense to the user to change them and most of users should'nt have done that.
- if sysadmin wants it to be started in a normal GNOME session (or Xfce or <whatever>), I guess we shouldn't remove his/her added .desktop autostart file each time they upgrade netbook-launcher. So, the version comparison is a little over-engineering compared to issues/bugs we can get without it.
- Even though we don't really user to change them, if it's the case, the file is renamed netbook-launcher.desktop.dpkg-new and so, not started at the session logon (I tested it when preparing the patch).

I think it's ready to be sponsored (I susbcribed u-m-s yesterday evening and I can see it, have I done something wrong?), but I can add this optional ';;' if you prefer.

FYI, seb thinks that we could handle it differently in the future (with gconf keys), removing those .desktop file. This first step enable experiencing une session in parallel than a regular desktop session and we'll see if improvement have to be done.

Revision history for this message
Loïc Minier (lool) wrote :

esac: Hmm I lived all this time thinking it was a syntax error; I think it's nicer to include it all the time, but it's fine as is too.

Otherwise sounds good, thanks; sorry, I missed the re-subscription of sponsors yesterday

Changed in maximus (Ubuntu):
assignee: nobody → Loïc Minier (lool)
Changed in netbook-launcher (Ubuntu):
assignee: nobody → Loïc Minier (lool)
Changed in maximus (Ubuntu):
status: Triaged → Fix Committed
Changed in netbook-launcher (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package netbook-launcher - 2.1.12-0ubuntu4

---------------
netbook-launcher (2.1.12-0ubuntu4) lucid; urgency=low

  * debian/netbook-launcher.install: install autostart desktop file in
    etc/xdg/xdg-une/autostart for launching in une session only (LP: #496301)
  * debian/{pre,post}inst: handle conffile move
 -- Didier Roche <email address hidden> Mon, 14 Dec 2009 21:55:33 +0100

Changed in netbook-launcher (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package maximus - 0.4.14-0ubuntu3

---------------
maximus (0.4.14-0ubuntu3) lucid; urgency=low

  * debian/rules: move autostart .desktop file to etc/xdg/xdg-une/
    (start only in une session) (LP: #496301)
  * debian/{pre,post}inst: handle conffile move
 -- Didier Roche <email address hidden> Mon, 14 Dec 2009 21:50:15 +0100

Changed in maximus (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Martin-Éric Racine (q-funk) wrote :

After upgrading to Lucid, I wondered why I not longer got full-screen windows, until I saw this in the Maximus changelog:

maximus (0.4.14-0ubuntu3) lucid; urgency=low

  * debian/rules: move autostart .desktop file to etc/xdg/xdg-une/
    (start only in une session) (LP: #496301)

PLEASE REVERT THIS CHANGE! There is NO valid reason for suddenly depriving ordinary GNOME users who like Maximus from having it auto-started as before.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

/etc/xdg is still on the admin power, so, you can just add a symlink from etc/xdg/autostart to etc/xdg/xdg-une/autostart.

All the session stuff (and those, now xubuntu et mythbuntu). Consequently, that's not going to change and it enables people to select more than one GNOME session (the other solution was to directly patch maximus to only enable it in UNE session, which is worse).

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.