[Sysmonitor] Sysmonitor fails to show Cpu Status for Quad Core Cpu correctly

[Alan Jordan]

Sysmonitor works correctly on my Laptop (Core 2 Duo CPU), but on my Desktop (Intel Core 2 Quad CPU Q9550), only three of the CPU Status boxes are displayed, and the third one is near the bottom righthand corner of the Sysmonitor, such that NO subsequent information is visible!

[bonestonne (l0rd-r0m30)]

Same problem with my Q9400. Worked fine with E6750.

[[e-mail] (paxton-jeffrey)]

I have exactly the same problem. The sysmonitor screenlet works fine on my ThinkPad T400 running an Intel Core 2 Duo. But on my desktop running AMD Anthon II X4 620 It shows only 3 cores. The first 2 in the expected location on the screen and the 3rd about half-way down the screen. When I enable "Show Cpus" no other data below the cpus is visible. How can I fix this?

[[e-mail] (paxton-jeffrey)]

If any one is having this prob try sysmonitor plus http://www.horejsek.com/download/smp0.8.2 It supports 4 core.

[Papp Bence (sclegnrbs)]

Can somebody check the new version from the PPA? (https://launchpad.net/~screenlets-dev/+archive/ppa)
and if there is a bug, please make a screenshot.

[Shofi Islam (shofi-islam)]

Had a look at the current source code for Maverick. I think there are the following bugs

1) For >4 cores, SysmonitorScreenlet.py, counts these from 1-4 instead of 0-3, causing the array to go out of bounds, hence show only 3 of the cores. This should be reset, and the hardcoded range removed, as this will fail with anything greater than 4 cores.

2) The positioning used to show the CPU graphs is off, again due to the CPU counting.

I am hacking a version of the code and can now see 4 cores. My working is attached, but please note the code is very rough.

[Märt Põder (boamaod)]

I applied your dirty fixes to latest developer version in http://bazaar.launchpad.net/~indiv-screenlets-dev/indiv-screenlets/trunk/view/head:/src/Sysmonitor/SysmonitorScreenlet.py and I suggest that you should use the latest development version if you try to fix something. The fixed version should be available for testing in next 24h in Screenlets Dev PPA (see https://launchpad.net/~screenlets-dev/+archive/ppa). If you want to fix something more, you can do it directly in Bazaar by joining Individual Screenlets Developers team.

[Shofi Islam (shofi-islam)]

Thanks for doing that. This is my first bug fix, so I'm not aware of what the correct process or tools are. I now have a clean fix available.

[Märt Põder (boamaod)]

I'd be glad if you applied your changes to the latest version of SysmonitorScreenlet (referred above in #6), so I can easily add them to the source. If you cannot find or run the latest source file, please say so, I can give you some directions.

Since the screenlets code has changed, it's really inconvenient to apply changes which you have done for some older version of the program. If you are already fixing the code, I suggest that you use the development version yourself (ppa:screenlets-dev/ppa, see http://www.screenlets.org/index.php/Download for some instructions).

[Shofi Islam (shofi-islam)]

I've added ppa:screenlets-dev/ppa and applied the changes as requested. Would you review and ensure I've got the right version, please.

[Märt Põder (boamaod)]

Thank you, Shofi Islam, the fix was really easy to add now, it is implemented in revision 932.

Please notice, that you can add fixes yourself using the Bazaar version control, since you are member of the team. If the fixes are rather small like this one and cannot possibly break anything in the code, you can just implement them and commit the code to the trunk branch. If you want to implement something bigger, you may want to discuss it in mailing list or IRC before starting to implement it in trunk.