Let community help person suspend user accounts
Bug #495126 reported by
Henning Eggers
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Henning Eggers |
Bug Description
When the community help person requests an account to be suspended by a LOSA (e.g. because it is a pure spam account), the LOSA uses IPerson:
It should be made accessible to the ~registry team (of which the CHR person is a member) but only display the status picker and the comment box to them.
Related branches
lp:~henninge/launchpad/bug-495126-deactivate-users
- Brad Crittenden (community): Approve (code)
- Edwin Grubbs (community): Needs Fixing
-
Diff: 495 lines (+174/-53)11 files modifiedlib/canonical/launchpad/doc/account.txt (+7/-2)
lib/canonical/launchpad/interfaces/account.py (+8/-8)
lib/canonical/launchpad/security.py (+36/-25)
lib/canonical/launchpad/zcml/account.zcml (+4/-1)
lib/lp/registry/browser/configure.zcml (+1/-1)
lib/lp/registry/browser/person.py (+29/-6)
lib/lp/registry/doc/person-account.txt (+2/-2)
lib/lp/registry/stories/person/xx-admin-person-review.txt (+55/-1)
lib/lp/registry/templates/person-review.pt (+2/-1)
lib/lp/services/permission_helpers.py (+29/-4)
lib/lp/translations/model/translationimportqueue.py (+1/-2)
Changed in launchpad-registry: | |
status: | New → Triaged |
importance: | Undecided → Low |
tags: | added: chr losa |
Changed in launchpad-registry: | |
assignee: | nobody → Henning Eggers (henninge) |
status: | Triaged → In Progress |
Changed in launchpad-registry: | |
milestone: | none → 10.01 |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad-registry: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
<sinzui> henninge: in security.py add ReviewByRegistr yExpertsOrAdmin s): moderate' ModeratePerson) : pastebin. ubuntu. com/338783/
<sinzui> class ModeratePerson(
<sinzui> permission = 'launchpad.
<sinzui> usedfor = IPerson
<sinzui> then change EditAccount to
<sinzui> class EditAccount(
<sinzui> henninge: I am mistaken I think. The user needs access to his account (to deactivate it) so the permission may need to remain launchpad.Edit
<henninge> sinzui: remain lp.Edit for EditAccount?
<henninge> ok, I'll put that in a bug.
<sinzui> henninge: I think so
<sinzui> henninge: I think the code needs to look like this: http://