Advanced Search Screen - "enter" doesn't work on 2nd, 3rd, etc. search input boxes

Bug #494734 reported by Cynthia W
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Status tracked in Main
2.0
Fix Released
Low
Unassigned
2.1
Fix Released
Low
Unassigned
Main
Fix Released
Low
Dan Scott

Bug Description

EG 1.404 and 1.6
OpenSR: 1.2
PostgreSQL: 8.2
Linux: Ubuntu 8.04

When you use the 2nd, 3rd and subsequent search input boxes you cannot use the "enter" key to start your search (you can from the basic search screen and the first input box on the advanced screen), you are forced to click the "submit search" button.
I've checked other institutions' OPACs, this happens elsewhere, it is not a problem local to our OPAC.

tags: added: opac ui
removed: advanced
James Fournie (jfournie)
Changed in evergreen:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Confirmed in 2.0 b4 OPAC and staff client. I don't know if we should set a milestone for fixing this.

Revision history for this message
Michael Peters (mrpeters) wrote :

I know this is way old, but I poked at it in Firebug today, running master as of 10/4/11.

I noticed that the first box, which allows the "Enter" key to submit, has a <tr id="adv_global_trow">. interestingly, the subsequent rows have an empty string in that id field.

This is most certainly what's causing the original bug report. This can be confirmed by clicking "Add Search Row", which will then also have the <tr id="adv_global_trow"> properly set. From that 4th search box, you're able to press "Enter" and get results.

I believe advSubmitGlobal(); is ignoring those fields without a proper id, but I'm not sure why just yet, since search functions OK if you actually click the submit button.

Revision history for this message
Michael Peters (mrpeters) wrote :

I've pushed a fix for this to user/mrpeters-isl/adv_search_enter on the public Git repo.

This adds two new entries, adv_global_trow2 and adv_global_trow3 to replace the previously empty id values.
This allows the user to enter search terms in any of the 3 search boxes, hit the Enter key, and then get results.
Previously, it was only possible to start a search by using the first box, adv_global_trow, or by adding a new row and then
pressing Enter on the keyboard, or by clicking the "Submit" button.

tags: added: pullrequest
Changed in evergreen:
status: Confirmed → Triaged
status: Triaged → In Progress
Revision history for this message
Thomas Berezansky (tsbere) wrote :

I've pushed an alternate implementation to user/tsbere/adv_search_enter that doesn't rely on specific IDs being in place, but simply changes the initial setup to a loop over all search rows.

Revision history for this message
Dan Scott (denials) wrote :

Committed from master through rel_2_0. Thanks, Thomas, for the elegant fix!

Changed in evergreen:
assignee: nobody → Dan Scott (denials)
status: In Progress → Fix Committed
milestone: none → 2.2.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.