libplist should be promoted to main.

Bug #494536 reported by Sebastien Bacher
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libplist (Ubuntu)
Fix Released
Wishlist
Unassigned
Changed in libplist (Ubuntu):
importance: Undecided → Wishlist
Martin Pitt (pitti)
Changed in libplist (Ubuntu):
assignee: nobody → Alexander Sack (asac)
Revision history for this message
Loïc Minier (lool) wrote :

I had a quick look; even if the testsuite is rather small, it would be nice to enable it since a generic C library for parsing plist files. This would give us confidence when adding patches, or allow us to drop new tests in there when we fix bugs -- to avoid regressions.

Alexander said he reviewed this already, so I'll defer to him for the full review.

Revision history for this message
Alexander Sack (asac) wrote :

this is ok for me.

a few build warnings that would be great to fix:

1. strict-aliasing type punning -> consider to use -fno-strict-aliasing
2. unused return values from fread -> should be fixed for real code (in tests its ok).

also if we could get the testsuite enabled that would be even better ... for me just running ctest didnt work though, so it might need some clarification.

file bugs for those, but that shouldnt hold back main promotion.

Changed in libplist (Ubuntu):
status: New → In Progress
Revision history for this message
Loïc Minier (lool) wrote :

MIR mentions Ubuntu Desktop will take responsability of this, so please subscribe the team to the source package.

It's great to see that Julien Lavergne is actively maintaining it in Debian and sub-ed to the Ubuntu bugs too.

Revision history for this message
Julien Lavergne (gilir) wrote :

Test suit is fixed upstream. I'll enable it in the next upload.

Revision history for this message
Loïc Minier (lool) wrote :

Great, thanks!

Revision history for this message
Jonathan Riddell (jr) wrote :

Should this be promoted? Please set to confirmed if so

Revision history for this message
Martin Pitt (pitti) wrote :

It won't be promoted until something will actually pull it into main, i. e. if there is a reverse (build) dependency to it.

Changed in libplist (Ubuntu):
assignee: Alexander Sack (asac) → nobody
Revision history for this message
Sebastien Bacher (seb128) wrote :

libgpod build-depends on libplist-dev now, I've promoted it, closing the bug

Changed in libplist (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.