Users not notified in email when subscribed by someone else

[Brian Murray]

I set the contact address for the Ubuntu Bug Control team to the team's
mailing list - <email address hidden> . I then
subscribed the team to bug 481788 however, there has been no mail to the
mailing list about being subscribed to the bug report. Additionally,
there are no messages pending moderation.

Barry says:

14:57 <barry> i'll try to recreate this situation, but it should work
15:02 <barry> what kind of mail was this, a comment on a bug? a change
in status/importance/assignee?
15:13 <bdmurray> subscription to the bug report
15:13 <bdmurray> so new notification of it
15:29 <barry> i can't any bugmail to work locally and i'm not sure why

 affects launchpad
 assignee sinzui

--
Brian Murray @ubuntu.com

[Barry Warsaw (barry)]

Curtis: See lib/canonical/launchpad/mailman/monkeypatches/lphandler.py for the key bit and why I think this should work. Also, I definitely got it working for answers before I ran out of time. There are unit tests for answers (I'm sure) but not positive about bugmail.

[Curtis Hovey (sinzui)]

Sending to a team via the contact this team features works as expected for teams that have set their contact address to the list. I think this error is in launchpad-bugs.

[Curtis Hovey (sinzui)]

I subscribed ~haibunku to a real bug then updated the bug comment. I and the list both got the email. I cannot reproduce this problem. I did not test the case where the bug as zillions of subscribers with duplicates.

[Curtis Hovey (sinzui)]

barry, out of curiosity, did you confirm that this is broken in dev by changing a bug then running ./cronscripts/send-bug-notifications.py to process the queue? Answers does not use a queue; it sends directly.

[Barry Warsaw (barry)]

I did not. That makes perfect sense. I wonder, should 'make run_all' occasionally run the cronscripts?

[Barry Warsaw (barry)]

Oh, I should also mention that I tested this in staging and never saw the bugmails show up in the staging or staging-mailman inbox. We should double check that staging is running the cronscripts.

[Martin Pitt (pitti)]

I actually notice that ocasionally as well. Sometimes people subscribe me or ~ubuntu-sru to a bug, and I never get a mail, but often it also works. One recent particular example is bug 493788 where Chris Coulson subscribed me, and I never got a bug mail

[Martin Pitt (pitti)]

This always seems to work for bug followups which happen after the subscription, just not if someone only subscribes me without changing/adding anything new.

[Brian Murray (brian-murray)]

I modified the tags on bug 481788, which I was testing with, and an e-mail did appear on the ubuntu bug control mailing list. However, I wanted to use this to notify the team by just subscribing them to a bug report - not subscribing them and modifying the bug.

[Deryck Hodge (deryck)]

So I I think this is a problem in our "You have been subscribed to a public bug by" message sending. I don't think this has anything to do with the mailing list. I know I didn't get a "you have been subscribed" message yesterday when I had Karl Fogel subscribe me to a bug. A search of my mail archives shows a July email as the latest email of this kind to me. I'm fairly certain I've been subscribed by people to bugs since then.

[Brian Murray (brian-murray)]

Is there a time frame for fixing this at all?

[Deryck Hodge (deryck)]

Not yet, no. I'll look closer tomorrow at when this can be scheduled.

[Ursula Junque (ursinha)]

Fixed in stable r10684 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10684>

[Deryck Hodge (deryck)]

This still doesn't seem to be working, so I'm marking it qa-bad. I need to do a bit more poking later about what exactly is going wrong.

[Brian Murray (brian-murray)]

It's not exactly clear to me why this moved to Fix Released when the bug has the tag qa-bad. Additionally, I had someone else subscribe me to bug 583931 and I have received no email message indicating that I was subscribed.

[Deryck Hodge (deryck)]

The branch attached to this bug is finished, qa-ok, and released. The part that was qa-bad was fixed in a related branch that was a security fix, so I didn't comment initially when that the work was done. I was just marking a group of bugs fix released and not paying much attention to the bugs.

The initial problem was that the notify call that generates the activity/email was done from browser code not model code, and the API calls are based on the model. So the js subscribe-someone-else widget wasn't hitting the notify call. My branch for this bug did the work to move all this to model code. That is done, tested, and deployed. There is still bug 571821 to do, which is an easy fix to call Bug.subscribe with the new parameter. I just haven't got to it yet, but I'll do it this week and notifications should appear again. Once 571821 is fixed, this bug can be closed.