Diff always gives an internal server error

[Matt Giuca]

I am always seeing this, on a URL such as http://ivle.localhost/diff/studentb/ivle-102/group1/hello.py?r=3&r=2.

IVLE Internal Server Error
<snip>
Traceback (most recent call last):
  File "/usr/local/lib/python2.6/dist-packages/ivle/dispatch/__init__.py", line 161, in handler
    view.render(req)
  File "/usr/local/lib/python2.6/dist-packages/ivle/webapp/base/xhtml.py", line 68, in render
    self.populate(req, viewctx)
  File "/usr/local/lib/python2.6/dist-packages/ivle/webapp/filesystem/diff/__init__.py", line 70, in populate
    response['error'])
AssertionError: Unknown error from diffservice: Can't open '/tmp/svndiff/tempfile.tmp': No such file or directory (code 2)

Could be related to #456913.

[William Grant (wgrant)]

On Tue, 2009-12-08 at 07:12 +0000, Matt Giuca wrote:
> Public bug reported:
>
> I am always seeing this, on a URL such as
> http://ivle.localhost/diff/studentb/ivle-102/group1/hello.py?r=3&r=2.
>
> IVLE Internal Server Error
> <snip>
> Traceback (most recent call last):
> File "/usr/local/lib/python2.6/dist-packages/ivle/dispatch/__init__.py", line 161, in handler
> view.render(req)
> File "/usr/local/lib/python2.6/dist-packages/ivle/webapp/base/xhtml.py", line 68, in render
> self.populate(req, viewctx)
> File "/usr/local/lib/python2.6/dist-packages/ivle/webapp/filesystem/diff/__init__.py", line 70, in populate
> response['error']
> AssertionError: Unknown error from diffservice: Can't open '/tmp/svndiff/tempfile.tmp': No such file or directory (code 2)
>
> Could be related to #456913.
>
> ** Affects: ivle
> Importance: High
> Status: New

I saw this last week too, but assumed it to be a local problem.

 status triaged
 assignee wgrant

[William Grant (wgrant)]

Gnargh. I hate you, Subversion. It looks like the diff() tempfile
behaviour has changed in Karmic.

The following diff solves it for Karmic, but I doubt it will work on
Jaunty or earlier. Need to investigate.

=== modified file 'services/diffservice'
--- services/diffservice 2009-12-02 01:25:02 +0000
+++ services/diffservice 2009-12-08 08:41:59 +0000
@@ -48,7 +48,7 @@
     svnclient = pysvn.Client()
     svnclient.exception_style = 1
     diff = svnclient.diff
- diff_text = diff( '/tmp/svndiff',
+ diff_text = diff( '/tmp',
         os.path.join('/home', sys.argv[1]),
         revision1=revs[0],
         revision2=revs[1]

[William Grant (wgrant)]

Fixed in trunk r1476.