No rebuild option if have upload privileges via per-package rights

[Robert Ancell]

I have upload privileges to desktop packages in main as I am a member of the ubuntu-desktop team. However if a build fails and I want to retry it I do not have a link to do this from Launchpad. People who are main uploaders do have this option.

i.e.
1. I uploaded xscreensaver
2. LP notifies me by email that it failed to build on ia64
3. I go to the build log to see why:
https://edge.launchpad.net/ubuntu/+source/xscreensaver/5.10-3ubuntu1/+build/1375403
4. Realising it was an error in a dependant package I want to rebuild but I don't have the option

Note that this kind of error seems to be quite frequent and I currently have to find someone with main privileges to perform the retry

[Julian Edwards (julian-edwards)]

The security adapter is not taking package sets into account, so if the upload permission is via a package set then it won't get build edit rights

Instead of calling IArchive.canUpload(), it should call archiveuploader.permission.check_upload_to_archive() which works properly with package sets.

[Julian Edwards (julian-edwards)]

FWIW you can also find buildd admins to retry the build until this is fixed.

[Jonathan Thomas (echidnaman)]

Yeah, it's just a bit of a hassle for all involved to do so. ;-)

[Michael Nelson (michael.nelson)]

I was just trying to demo this locally but failed:

http://pastebin.ubuntu.com/391911/

Adding a permission for the specific package name enables the 'Retry this build' option. So either my local test setup is faulty (we could try a team permission), or this actually works. We should run a query to verify the expected permission for the ubuntu-desktop team and the xscreensaver package.

[William Grant (wgrant)]

It's both a package set and a team permission.

[Steve Kowalik (stevenk)]

Testing this configuration where a demo user is a part of a team and the team has permission also works as expected.

[Michael Nelson (michael.nelson)]

@wgrant: Right - I demo'd a permission for a specific package, rather than a package set. Thanks.

[Ursula Junque (ursinha)]

Fixed in stable r10520 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10520>