Rhythmbox MusicBrainz cover art search engine fails to load available cover art

Bug #492658 reported by Medor
36
This bug affects 7 people
Affects Status Importance Assigned to Milestone
rhythmbox (Ubuntu)
Invalid
Low
Ubuntu Desktop Bugs

Bug Description

Binary package hint: rhythmbox

Rhythmbox not load cover arts and i not see progress icon in progress bar panel...
connection to the Internet is present

ProblemType: Bug
Architecture: i386
Date: Sat Dec 5 00:26:45 2009
DistroRelease: Ubuntu 9.10
ExecutablePath: /usr/bin/rhythmbox
InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release i386 (20091028.5)
Package: rhythmbox 0.12.5-0ubuntu5.1
ProcEnviron:
 LANG=uk_UA.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-14.48-generic
SourcePackage: rhythmbox
Uname: Linux 2.6.31-14-generic i686

Revision history for this message
Medor (bogkuz) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better. Please answer these questions:

 * Is this reproducible?
 * If so, what specific steps should we take to recreate this bug?

 This will help us to find and resolve the problem.

Changed in rhythmbox (Ubuntu):
assignee: nobody → Ubuntu Desktop Bugs (desktop-bugs)
importance: Undecided → Low
status: New → Incomplete
Revision history for this message
Medor (bogkuz) wrote :

I dont now what staps is recreating this bug....
May be my automatic attachments help you?
Banshe loads cover arts successfully
In ~/.cache/rhythmbox/covers rhythmbox make something like Depeche Mode - Ultra.rb-blist with text DiscogsCoverArtSearch
Reinstailing rhythmbox and deleting /home/bogdan/.gconf/apps/rhythmbox get no effect
...
In start-up process in termsnsl rhythmbox write:

** (rhythmbox:21786): CRITICAL **: atk_object_set_name: assertion `name != NULL' failed

** (rhythmbox:21786): CRITICAL **: atk_object_set_name: assertion `name != NULL' failed

Revision history for this message
Victor Vargas (kamus) wrote :

@Medor, Since your report has a time without activity, is this issue still affecting you? In case this behaviour is actually present please could you run rhythmbox --debug &> rhythmbox-debug.txt and attach the resulting file to the report, Thanks in advance.

Revision history for this message
Loewi (nonphotochemicalquenching) wrote :

This issue is affecting me as well.

No cover art is downloaded
attached is the rhythmbox-debug.txt

Thanks!

Revision history for this message
lannatwin (lannatwin) wrote :

I am having this problem with Linux Mint Release 9.

Here is some debug data:
(rhythmbox:6021): Rhythmbox-DEBUG: Received SaveYourself(SmSaveLocal, !Shutdown, SmInteractStyleNone, !Fast) in state idle
(rhythmbox:6021): Rhythmbox-DEBUG: Setting initial properties
(rhythmbox:6021): Rhythmbox-DEBUG: Sending SaveYourselfDone(True) for initial SaveYourself
(rhythmbox:6021): Rhythmbox-DEBUG: Received SaveComplete message in state save-yourself-done
(10:53:08) [0x1a7baf0] [LocalCoverArtSearch.search] /usr/lib/rhythmbox/plugins/artdisplay/LocalCoverArtSearch.py:180: not searching for local art for cdda://1/#/dev/sr0
(10:53:08) [0x1a7baf0] [EmbeddedCoverArtSearch.search] /usr/lib/rhythmbox/plugins/artdisplay/EmbeddedCoverArtSearch.py:164: not checking for embedded cover art in playing entry
(10:53:08) [0x1a7baf0] [LastFMCoverArtSearch.search] /usr/lib/rhythmbox/plugins/artdisplay/LastFMCoverArtSearch.py:236: can't search: no last.fm account details
(10:53:08) [0x1a7baf0] [MusicBrainzCoverArtSearch.search] /usr/lib/rhythmbox/plugins/artdisplay/MusicBrainzCoverArtSearch.py:156: stripped release ID: 1ef44e46-9c88-4a8e-ab70-9cbe531f54df
(10:53:08) [0x8cf040] [MusicBrainzCoverArtSearch.__get_release_cb] /usr/lib/rhythmbox/plugins/artdisplay/MusicBrainzCoverArtSearch.py:106: got ASIN B000002O2B
(10:53:08) [0x8cf040] [MusicBrainzCoverArtSearch.__get_release_cb] /usr/lib/rhythmbox/plugins/artdisplay/MusicBrainzCoverArtSearch.py:113: exception parsing musicbrainz response: 'MusicBrainzCoverArtSearch' object has no attribute 'get_result_meta'

Robert Lange (rcl24)
Changed in rhythmbox (Ubuntu):
status: Incomplete → Opinion
status: Opinion → In Progress
Revision history for this message
Robert Lange (rcl24) wrote :

This bug is a simple omission in a search handler. In MusicBrainzCoverArtSearch.py, someone forgot to implement the method get_result_meta. It's just a stub that does nothing important, but the overall search algorithm expects it to be there, and when it's not, it returns a runtime error rather than trying the found URL. Basically, this would be a compile error if it were a C program, but since it's Python, it becomes a cryptic runtime error.

Attached is a patch which fixes this bug. It implements a stub for get_result_meta, which causes the MusicBrainz search handler to happily download the album art.

summary: - Rhythmbox not load cover arts
+ Rhythmbox MusicBrainz cover art search engine fails to load available
+ cover art
Revision history for this message
lannatwin (lannatwin) wrote :

I solved this by making sure I was logged into LastFM. A note about it in the documentation would be very helpful.

http://forums.linuxmint.com/viewtopic.php?f=48&t=48876

tags: added: patch
Revision history for this message
Robert Lange (rcl24) wrote :

Yeah, lannatwin, Last.FM is another search option that is automatically tried, if you are logged in to it. However, my patch fixes things even for those who do not have a Last.FM account.

Revision history for this message
Medor (bogkuz) wrote :

Applying patch got me error msg about cover plugin...

Revision history for this message
Robert Lange (rcl24) wrote :

Medor, we need more information to determine if this error is really related to the patch. Please quit Rhythmbox (making sure it's not still running in the background) and from the command line, run:

rhythmbox --debug >rhythmbox-debug.txt 2>&1

Start playing one album/song that causes the error, wait for the error to appear, and then quit rhythmbox and wait for the command line instance to return to the prompt. Then, please attach the file for us to look at.

Revision history for this message
Medor (bogkuz) wrote :

Here it is...
...
My system is ubuntu 10.10
...
Error msg is shown when i try to turn on the lyrics plugin in menu

Revision history for this message
Robert Lange (rcl24) wrote :

It looks like the patch was not properly applied, or else, your initial copy of /usr/lib/rhythmbox/plugins/artdisplay/MusicBrainzCoverArtSearch.py was different than mine.

Can you attach your copy, as well as the initial copy, if it still exists?

Revision history for this message
Medor (bogkuz) wrote :

Robert Lange
may be .. i have no experience with attaching paches...

Revision history for this message
Robert Lange (rcl24) wrote :

All,

The above solution patch is formatted to be dropped into the Ubuntu source package and recompiled into the binary package. However, since it's just a Python file, you can just apply it directly to the /usr/lib/rhythmbox/plugins/artdisplay/MusicBrainzCoverArtSearch.py file without building a new binary package, using the following commands:

cd /usr/lib/rhythmbox/plugins/artdisplay/
sudo patch -p4 < /full/path/to/solution_file

-----

Medor: Whatever editor you used to copy-paste the diff contents into your file, it messed up the indentation by replacing all tabs with the wrong number of spaces. Python is a whitespace-sensitive language, and for better or worse, the authors of this file have used tabs to indent, so we need to fix your indentation. To fix it, you need to make sure there is exactly 1 tab before the first line of the fix, and exactly 2 tabs before the second line. These need to be actual tabs, not spaces, so you will have to make sure your editor is not set to replace tabs with spaces. (If you use Emacs (with a default .emacs configuration file; I can't vouch for all customizations...), the first line of the MusicBrainzCoverArtSearch.py file will auto-configure Emac's tab-mode for this file for you. I don't know what other editors respect that line.)

Revision history for this message
Medor (bogkuz) wrote :

I applying patch using

cd /usr/lib/rhythmbox/plugins/artdisplay/
sudo patch -p4 < /full/path/to/solution_file

and get nothing. covers not download

Revision history for this message
Shaun Keller (shaun-keller) wrote :

I experienced this problem on a fresh desktop 32-bit 10.10 installation I just made on a Parallels VM hosted on OS X and manually modified MusicBrainzCoverArtSearch.py with the patch to add method get_result_meta. This fixed the bug for me. I suggest committing the patch to trunk and closing the bug.

Revision history for this message
pierre-antoine roiron (contact-guitares-roiron) wrote :

I experienced this issue too on a Ubuntu 10.10 64bit. Applying the patch solved the problem.

Revision history for this message
Eduard Gotwig (gotwig) wrote :

This problem is still present in 12.04 . WHY?

Revision history for this message
Robert Lange (rcl24) wrote :

This bug appears to have been fixed in 12.10. I was able to use MusicBrainz to get album info and cover art for my CDs.

The fix appears not to have been the application of my patch, but a general refactoring of the module.

Unless someone else can confirm that this bug still exists in 12.10 (which I seriously doubt) then this bug should be closed.

Changed in rhythmbox (Ubuntu):
status: In Progress → Incomplete
Changed in rhythmbox (Ubuntu):
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.