[PATCH] Add option to view all entries in pager

Bug #492307 reported by Maximilian Gaß
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Web Client
Fix Released
Undecided
Unassigned

Bug Description

The list view has a pager that can show a variable amount of entries. This patch adds the possibility show all entries.

Maximilian Gass, credativ

Revision history for this message
Maximilian Gaß (mxey) wrote :
Revision history for this message
Sananaz (Open ERP) (sma-tiny) wrote :

Hello,

Its not good to show all entries which is stored in database. May be its more than 500 or 1000 (ex: in objects, fields listview) so it causes to slow the procedure.

Thanks.

Changed in openobject-client-web:
status: New → Invalid
Revision history for this message
Alex Joni (alex-joni) wrote :

Why is it a problem to have an "option" for the user to select? If he selects all and it's slow it's his fault/problem.

Revision history for this message
Maximilian Gaß (mxey) wrote :

What about adding extra entries above 100, like 200, 500 and 1000?

Changed in openobject-client-web:
status: Invalid → In Progress
Revision history for this message
Sananaz (Open ERP) (sma-tiny) wrote :

Hello,

Here attach a patch to resolve your problem please apply in stable and notify us.

you can define options on the OpenERP Web Client config file.
listgrid.pager.min = 20
listgrid.pager.max = 100
listgrid.pager.steps = 20

Thank you.

Revision history for this message
Maximilian Gaß (mxey) wrote :

The patch seems to work fine.

However, the grid in the search popup still has a default limit of 20. Could you extend the patch to control that grid as well?

Revision history for this message
Sananaz (Open ERP) (sma-tiny) wrote :

Hello Maximilian Gass,

You are right. But for Search its necessary to define default limit.
After getting list you can change from Change Limit option where you can get desire steps,
which you have define in config file.

Thanks.

Revision history for this message
Maximilian Gaß (mxey) wrote :

Why not provide an option to set the default as well? I think the .min option could also work as a default limit.

Changed in openobject-client-web:
status: In Progress → Fix Committed
Revision history for this message
Borja López Soilán (NeoPolus) (borjals) wrote :

Hi sma, I've been testing the patch*, and it seems to work (though there is a related bug causing me some problems: https://bugs.launchpad.net/openobject-client-web/+bug/512400).

* I had to apply it manually as Bazaar would reject the merge on the last revision (2844).

I'm attaching my own patch that works on the 2844 revision and that combines also the "show all entries in pager" patch. This means that the user will be able to configure it as he wants, but will also be able see all the records if he really needs so. (It solves both this bug and the https://bugs.launchpad.net/openobject-client-web/+bug/522678 bug).

Revision history for this message
Sananaz (Open ERP) (sma-tiny) wrote :

Hello,

Its fixed in stable. Please update your code.

Revision Info:
2854 <email address hidden>

Thanks.

Changed in openobject-client-web:
status: Fix Committed → Fix Released
Navrang Oza (noz-tiny)
Changed in openobject-client-web:
milestone: none → 5.0.10
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.