bzr branch auto name should remove .git

[Gary van der Merwe]

If you run
bzr branch FROM_LOCATION
without TO_LOCATION specified, bzr decides on a name for the TO_LOCATION. When using bzr-git, it should remove the .git from this name.

Steps to reproduce:
bzr branch git://github.com/simonw/django-openid.git

Actual results:
branched created at django-openid.git

Expected results:
branched created at django-openid

[Jelmer Vernooij (jelmer)]

The name is determined by bzr, not by bzr-git

[Martin Pool (mbp)]

2009/12/18 Jelmer Vernooij <email address hidden>:
> The name is determined by bzr, not by bzr-git

Perhaps we should ask the source branch object for the recommended
destination directory name?

--
Martin <http://launchpad.net/~mbp/>

[Jelmer Vernooij (jelmer)]

Perhaps it might be useful to allow Branch implementations to suggest
names for derived branches. It would be strange to remove ".git" as
suffix from the name of a regular bzr branch.

[John A Meinel (jameinel)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> The name is determined by bzr, not by bzr-git
>
> ** Project changed: bzr-git => bzr
>

It sounds like we should provide a hook that bzr-git could use. I don't
think we want to hard-code inside bzr
if url.endswith('.git'):
 url = url[:-4]

We could, but a more flexible "map source name to default output name"
seems better.

Then again, just because another tool does it that way doesn't mean we
have to. The user can just as easily give a target name....

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksq4L8ACgkQJdeBCYSNAAP2+wCaAsi7u/mnLDhxkh91WBj/Cnni
j50AoI0J3Trxa+jZJsj+IZP8N0bglO8S
=Jbdb
-----END PGP SIGNATURE-----

[Jelmer Vernooij (jelmer)]

On Fri, 2009-12-18 at 01:48 +0000, Martin Pool wrote:
> 2009/12/18 Jelmer Vernooij <email address hidden>:
> > The name is determined by bzr, not by bzr-git
>
> Perhaps we should ask the source branch object for the recommended
> destination directory name?
Yes, that would be a good idea I think.

Cheers,

Jelmer