Separate username and password validation on Log In screen

[George]

Hi Anand,

On the Upstream Log In screen, if I enter either an incorrect username or password, I need to be informed of which of them is incorrect, or if they are both incorrect.

I just tested the login, and entered an incorrect password with my normal username. The error message said: "Invalid username or password"

1) If the username is incorrect, we need to display a message that reads "The username you entered isn't in the Open Library system. Please try again?"

2) If the password is incorrect, we need to display a message that reads "That password seems incorrect. Please try again, or, if you've forgotten it, have your _password reset_."

3) If both username and password are incorrect, just show both messages. (Though, ideally, we would provide a third note that reads "Hmm... We don't recognize the username or the password you supplied. Please try again?")

* Note, errors should read as complete sentences, with punctuation
* If you'd like me to write things for you, that's absolutely no problem.

[Edward Betts (edwardbetts)]

The code is in /vendor/infogami/infogami/infobase/server.py

The logic needs to change to check if a user exists before trying to login.

[Anand Chitipothu (anandology)]

We can first check existence of the user by testing /people/$username page.

[Anand Chitipothu (anandology)]

handled case#1 and #2.

Case#3 doesn't make sense because it is not possible to have wrong username and right password.

Error messages are specified in:
http://upstream.openlibrary.org/templates/errors.tmpl

[George (george-archive)]

Sweet! Thank you very much for getting to this - it's a pet peeve relieved!