Launchpad will import comments for all a bug's bug watches

[Fabien Tassin]

What happens:
If a bug has a bug watch against an upstream bug, even if that upstream bug has nothing to do with the actual bug.

For example, bug 454166 was fixed by a change to a package and the changelog was posted to the bug as a comment by the LP Janitor. This comment contained the URL of an upstream bug, so a bug watch was created for that upstream bug.

Checkwatches then imported the comments from that upstream bug, even though the upstream bug had nothing to with the Launchpad bug. (see http://paste.ubuntu.com/333331/ for the resulting bugspam).

What should happen:
Checkwatches should only import comments when a bug watch is actually linked to a BugTask. That will eliminate this problem (unless someone adds a nonsensical BugWatch to a BugTask, but we can't prevent users from doing odd things all the time).

[Curtis Hovey (sinzui)]

Hi Graham.

My brain hurst looking at this. This does look like the wrong comments on the bug. Can you triage this?

[Graham Binns (gmb)]

Right, this crackpottery occurs because there's a bug watch against an upstream bug. That the upstream bug has absolutely nothing to do with the bug in Launchpad (it just happens to be mentioned in a comment and the watch is auto-generated) has nothing to do with anything; Launchpad just cheerfully imports the comments anyway.

This is bong, and I'll update this bug accordingly to describe how we should fix this.