[patch] tabindex in connectionTestForm.dtml

Bug #491249 reported by NicDumZ
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zope 2
Fix Released
Undecided
Unassigned

Bug Description

Hello!

I find it handy to use tabindex in connectionTestForm. It allows accessing the main textarea in one tab.

But the fact that no tabindex is defined for the submit button means that after having entered the sql string in the textarea, if one wants to tabulate to the submit button, he will have to go through all the page layout before eventually hitting submit.

Simple fix: add tabindex=2 for the submit button.

Thanks.

Tags: patch
Revision history for this message
NicDumZ (nicdumz) wrote :
Revision history for this message
Tres Seaver (tseaver) wrote : Re: [zope2-tracker] [Bug 491249] [NEW] [patch] tabindex in connectionTestForm.dtml

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

NicDumZ wrote:
> Public bug reported:
>
> Hello!
>
> I find it handy to use tabindex in connectionTestForm. It allows
> accessing the main textarea in one tab.
>
> But the fact that no tabindex is defined for the submit button means
> that after having entered the sql string in the textarea, if one wants
> to tabulate to the submit button, he will have to go through all the
> page layout before eventually hitting submit.
>
> Simple fix: add tabindex=2 for the submit button.

 status inwork
 assigned tseaver

- --
===================================================================
Tres Seaver +1 540-429-0999 <email address hidden>
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksWi6QACgkQ+gerLs4ltQ7ZZgCgnwKYViQzg3xT00WJBLyugRYK
08sAoKpcVQDquI4tlLXKKis4NL2W1YyN
=f6DC
-----END PGP SIGNATURE-----

Revision history for this message
Tres Seaver (tseaver) wrote : Re: [zope2-tracker] [Bug 491249] Re: [patch] tabindex in connectionTestForm.dtml

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

NicDumZ wrote:
> ** Attachment added: "Patch against r106156"
> http://launchpadlibrarian.net/36325125/tabindex.diff
>

 status fixcommitted
 assigned tseaver

Thanks for the patch! Checked into the 2.12 branch:

 http://svn.zope.org/Zope/branches/2.12/?rev=106175&view=rev

and the trunk:

 http://svn.zope.org/Zope/trunk/?rev=106176&view=rev

Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 <email address hidden>
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksWjRIACgkQ+gerLs4ltQ6DrwCgvC5/SI8fhKxnofF34cqs8mcO
NLgAn3wzuUw+03ygHH6PidfcuKXdNUbE
=amfu
-----END PGP SIGNATURE-----

Changed in zope2:
status: New → Fix Committed
Changed in zope2:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.