JavaScript code should not be requesting XHTML representations from the web service
Bug #490826 reported by
Māris Fogels
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Tim Penhey |
Bug Description
JavaScript in Launchpad should not be requesting the default XHTML representation from the webservice, just so it can cherry-pick the specific attributes that the code needs. Instead, the code should request just the fields it needs.
Related branches
lp:~thumper/launchpad/client-cache-sync
- j.c.sackett (community): Approve
-
Diff: 703 lines (+302/-102)14 files modifiedlib/lp/app/javascript/client.js (+101/-22)
lib/lp/app/javascript/lp.ui.js (+20/-0)
lib/lp/app/javascript/picker.js (+9/-39)
lib/lp/app/javascript/tests/test_lp_client.html (+1/-2)
lib/lp/app/javascript/tests/test_lp_client.js (+129/-4)
lib/lp/app/templates/base-layout-macros.pt (+11/-8)
lib/lp/app/templates/text-area-editor.pt (+2/-3)
lib/lp/app/templates/text-line-editor.pt (+1/-2)
lib/lp/bugs/javascript/tests/test_bug_subscription_widget.html (+1/-1)
lib/lp/bugs/javascript/tests/test_me_too.html (+1/-1)
lib/lp/bugs/javascript/tests/test_me_too.js (+5/-3)
lib/lp/bugs/javascript/tests/test_subscriber.html (+1/-1)
lib/lp/code/interfaces/sourcepackagerecipe.py (+9/-11)
lib/lp/code/templates/sourcepackagerecipe-index.pt (+11/-5)
tags: | added: tech-debt |
tags: | added: javascript |
Changed in launchpad-foundations: | |
importance: | Undecided → Low |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
On Tue, Dec 01, 2009 at 01:57:49PM -0000, Māris Fogels wrote:
> Public bug reported:
>
> JavaScript in Launchpad should not be requesting the default XHTML
> representation from the webservice, just so it can cherry-pick the
> specific attributes that the code needs. Instead, the code should
> request just the fields it needs.
I assume the plan is to remove the default XHTML representation as well,
so that people aren't tempted to use it?