'X branches proposed for merging' goes +merges not +activereviews on branch page
Bug #490139 reported by
Robert Collins
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Tim Penhey |
Bug Description
e.g on https:/
"5 branches proposed for merging into this one." links to a page
containing > 20 branches.
-Rob
affects launchpad-code
Related branches
lp:~thumper/launchpad/branch-active-reviews
Merged
into
lp:launchpad
- Michael Nelson (community): Approve (ui)
- Paul Hummer (community): Approve (code ui*)
-
Diff: 159 lines (+42/-21)6 files modifiedlib/lp/code/browser/branchmergeproposallisting.py (+12/-6)
lib/lp/code/browser/configure.zcml (+7/-0)
lib/lp/code/browser/tests/test_branchmergeproposallisting.py (+0/-14)
lib/lp/code/stories/branches/xx-branchmergeproposal-listings.txt (+16/-0)
lib/lp/code/templates/active-reviews.pt (+6/-0)
lib/lp/code/templates/branch-pending-merges.pt (+1/-1)
Changed in launchpad-code: | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Tim Penhey (thumper) |
milestone: | none → 10.01 |
Changed in launchpad-code: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Robert Collins wrote:
> Public bug reported:
> "5 branches proposed for merging into this one." links to a page
> containing > 20 branches.
Now it's "2 branches proposed...", and of the > 20 branches, one is
"Needs review" and one is "Approved".
I would like to see the +activereviews style used as the default
everywhere, with the +merges page linked as a way for people to see
inactive reviews.
Aaron
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org
T3hIACgkQ0F+ nu1YWqI055gCY43 fmW5bJYIkDTckpp 426DdjZ zRwVQVW43ZwUUd2 g=
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEUEARECAAYFAks
kgCeOUWVVw5INar
=rrcS
-----END PGP SIGNATURE-----