requesting code reviews puts the mp into a state where it can't be displayed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Tim Penhey |
Bug Description
i was playing with bug 456643 and bug 487327 by requesting reviews on <https:/
This ended up with this mp getting into a state where any attempt to view it gave oops-1427ec27.
I think what I was doing was just requesting reviews from myself and teams to which I belong, with different review types. I think this means (from looking at the traceback) lp got into a state where it allows multiple reviews to be requested in a category where it assumes there will be only one. It may be that you can create two review requests for one person with different types, but the rest of the system can't cope with that.
Related branches
- Michael Hudson-Doyle: Approve
- Jonathan Lange (community): Approve (db)
- Stuart Bishop (community): Approve (db)
- Guilherme Salgado: Pending (release-critical) requested
-
Diff: 96 lines (+53/-3)3 files modifieddatabase/schema/patch-2207-17-0.sql (+13/-0)
lib/lp/code/model/branchmergeproposal.py (+8/-3)
lib/lp/code/model/tests/test_branchmergeproposals.py (+32/-0)
Changed in launchpad-code: | |
status: | Triaged → In Progress |
Changed in launchpad-code: | |
status: | In Progress → Fix Committed |
Changed in launchpad-code: | |
milestone: | none → 3.1.12 |
status: | Fix Committed → Fix Released |
End state that meant it couldn't be shown:
name | review_type | name | vote_message | date_created ------- --+---- ------- --+---- ------- -----+- ------- ------+ ------- ------- ------- -------
-------
mbp | | jameinel | | 2009-10-06 17:50:49.727095
bzr | doc | mbp | | 2009-11-27 00:29:45.002283
mbp | doc | mbp | | 2009-11-27 00:29:29.739284
ian-clatworthy | <NULL> | ian-clatworthy | 34365 | 2009-10-14 05:29:50.174796