AppServer layer explodes during setUp when DB revision is incorrect

[Данило Шеган]

Unlike bin/test or 'make run', if DB has not been updated with 'make schema', running windmill tests fails with a failure how appserver can't be started instead of warning about database revision.

$ bin/test -vv --layer=TranslationsWindmillLayer
Running tests at level 1
Running lp.translations.windmill.testing.TranslationsWindmillLayer tests:
  Set up canonical.testing.layers.BaseLayer in 0.009 seconds.
  Set up canonical.testing.layers.DatabaseLayer in 0.347 seconds.
  Set up canonical.testing.layers.LibrarianLayer in 7.770 seconds.
  Set up canonical.testing.layers.LaunchpadLayer in 0.000 seconds.
  Set up canonical.testing.layers.FunctionalLayer in 4.702 seconds.
  Set up canonical.testing.layers.GoogleServiceLayer in 2.453 seconds.
  Set up canonical.testing.layers.LaunchpadFunctionalLayer in 0.000 seconds.
  Set up canonical.testing.layers.AppServerLayer Traceback (most recent call last):
  File "/home/danilo/launchpad/sourcecode/eggs/zope.testing-3.8.1-py2.5.egg/zope/testing/testrunner/runner.py", line 364, in run_layer
    setup_layer(options, layer, setup_layers)
  File "/home/danilo/launchpad/sourcecode/eggs/zope.testing-3.8.1-py2.5.egg/zope/testing/testrunner/runner.py", line 624, in setup_layer
    setup_layer(options, base, setup_layers)
  File "/home/danilo/launchpad/sourcecode/eggs/zope.testing-3.8.1-py2.5.egg/zope/testing/testrunner/runner.py", line 624, in setup_layer
    setup_layer(options, base, setup_layers)
  File "/home/danilo/launchpad/sourcecode/eggs/zope.testing-3.8.1-py2.5.egg/zope/testing/testrunner/runner.py", line 629, in setup_layer
    layer.setUp()
  File "/home/danilo/launchpad/trees/bug-487601/lib/canonical/testing/profiled.py", line 29, in profiled_func
    return func(cls, *args, **kw)
  File "/home/danilo/launchpad/trees/bug-487601/lib/canonical/testing/layers.py", line 1620, in setUp
    LayerProcessController.startAppServer()
  File "/home/danilo/launchpad/trees/bug-487601/lib/canonical/testing/profiled.py", line 29, in profiled_func
    return func(cls, *args, **kw)
  File "/home/danilo/launchpad/trees/bug-487601/lib/canonical/testing/layers.py", line 1468, in startAppServer
    cls._waitUntilAppServerIsReady()
  File "/home/danilo/launchpad/trees/bug-487601/lib/canonical/testing/layers.py", line 1585, in _waitUntilAppServerIsReady
    connection = urlopen(root_url)
  File "/usr/lib/python2.5/urllib.py", line 82, in urlopen
    return opener.open(url)
  File "/usr/lib/python2.5/urllib.py", line 190, in open
    return getattr(self, name)(url)
  File "/usr/lib/python2.5/urllib.py", line 328, in open_http
    errcode, errmsg, headers = h.getreply()
  File "/usr/lib/python2.5/httplib.py", line 1199, in getreply
    response = self._conn.getresponse()
  File "/usr/lib/python2.5/httplib.py", line 928, in getresponse
    response.begin()
  File "/usr/lib/python2.5/httplib.py", line 385, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python2.5/httplib.py", line 343, in _read_status
    line = self.fp.readline()
  File "/usr/lib/python2.5/socket.py", line 372, in readline
    data = recv(1)
IOError: [Errno socket error] (104, 'Connection reset by peer')

Tearing down left over layers:
  Tear down canonical.testing.layers.LaunchpadFunctionalLayer in 0.000 seconds.
  Tear down canonical.testing.layers.LaunchpadLayer in 0.000 seconds.
  Tear down canonical.testing.layers.LibrarianLayer in 0.403 seconds.
  Tear down canonical.testing.layers.GoogleServiceLayer in 0.061 seconds.
  Tear down canonical.testing.layers.FunctionalLayer ... not supported
  Tear down canonical.testing.layers.DatabaseLayer in 0.216 seconds.
  Tear down canonical.testing.layers.BaseLayer in 0.000 seconds.

Tests with errors:
   runTest (zope.testing.testrunner.runner.SetUpLayerFailure)

** 2 import policy violations **

There were 2 imports of names not appearing in the __all__.
You should not import domain_match from cookielib:
    canonical.launchpad.webapp.session
You should not import mktime_tz from email.Utils:
    canonical.launchpad.database.message

[Jonathan Lange (jml)]

The bug report is a little incorrect:

  * The reported behaviour occurs with any AppServer tests
  * bin/test itself does not warn about database revision, it also explodes, but with a different (and more helpful) error

To reproduce the bug, create a new database patch file (touch database/schema/patch-2207-17-0.sql), and run './bin/test -vv test_launchpadlib'.

To demonstrate the presumably expected behaviour, run './bin/test -vv test_branchcollection'. Note that the error happens during the layer's testSetUp.

I've produced a fix, and linked the branch to this report.

[Diogo Matsubara (matsubara)]

Fixed in devel r10009 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/revision/10009>