Allow Rosetta admins to create custom language codes
Bug #487137 reported by
Jeroen T. Vermeulen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Henning Eggers |
Bug Description
Now that we have the custom language codes UI (bug 271747), we should allow Translations experts to create and remove custom language codes.
This was always planned, but didn't fit in the original branch.
Related branches
lp:~adiroiban/launchpad/bug-487137
Rejected
for merging
into
lp:launchpad
- Michael Nelson (community): Approve (code)
-
Diff: 402 lines (+108/-57)9 files modifiedlib/canonical/launchpad/security.py (+24/-0)
lib/lp/translations/browser/configure.zcml (+3/-3)
lib/lp/translations/browser/customlanguagecode.py (+1/-1)
lib/lp/translations/stories/standalone/custom-language-codes.txt (+55/-47)
lib/lp/translations/templates/customlanguagecode-index.pt (+1/-1)
lib/lp/translations/templates/customlanguagecode-remove.pt (+18/-0)
lib/lp/translations/templates/customlanguagecodes-index.pt (+4/-3)
lib/lp/translations/templates/product-portlet-translatables.pt (+1/-1)
lib/lp/translations/templates/sourcepackage-translations.pt (+1/-1)
lp:~henninge/launchpad/devel-487137-custom-language-codes
- Curtis Hovey (community): Approve (ui)
- Jelmer Vernooij (community): Approve (code)
-
Diff: 561 lines (+175/-102)9 files modifiedlib/canonical/launchpad/security.py (+28/-0)
lib/lp/translations/browser/configure.zcml (+4/-4)
lib/lp/translations/browser/customlanguagecode.py (+10/-1)
lib/lp/translations/stories/standalone/custom-language-codes.txt (+108/-91)
lib/lp/translations/templates/customlanguagecode-index.pt (+1/-1)
lib/lp/translations/templates/customlanguagecode-remove.pt (+18/-0)
lib/lp/translations/templates/customlanguagecodes-index.pt (+4/-3)
lib/lp/translations/templates/product-portlet-translatables.pt (+1/-1)
lib/lp/translations/templates/sourcepackage-translations.pt (+1/-1)
Changed in rosetta: | |
importance: | Undecided → High |
status: | New → Triaged |
Changed in rosetta: | |
assignee: | nobody → Adi Roiban (adiroiban) |
Changed in rosetta: | |
status: | Triaged → In Progress |
Changed in rosetta: | |
status: | In Progress → Triaged |
Changed in launchpad: | |
assignee: | nobody → Henning Eggers (henninge) |
status: | Triaged → In Progress |
tags: | added: bugjam2010 |
Changed in launchpad: | |
milestone: | none → 11.01 |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
For IProduct we have the following admin permissions:
* registry admin - LP Admins and project owner
* translations admin - LP Admins, project owner and Rosetta Admins
* custom language code admin - LP Admins and Rosetta Admins
'Registry admin' is mapped to launchpad.Admin, while 'translations admin' is mapped to 'launchpad. TranslationsAdm in'
To solve this problem we have the following options
1. Allow project owners to administer custom language code. Danilo said that this is not an option right now. CustomLanguageC odeAdmin. From previous discussion on the LP-dev ML this is not the recommended solution. omLanguageCode, DistributionWit hCustomLanguage Code and SourcePackageWi thCustomLanguag e code object that will delegate IProduct, IDistribution... etc . From my point of view, this solution will only complicate the design of the code.
2. Add a new launchpad.
3. Create new ProductWithCust
Are there any other options?
If we are going to solve this bug, what option should we choose?