Launchpad itself

Bugs page times out when getting subscription_class for a person

Bug #487015 reported by Graham Binns
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Graham Binns
Launchpad itself 3.1.11

Bug Description

What happens:
Bug 393476 has been fixed but the bugs page still times out if there are many subscribers from duplicates.

What should happen:
The page shouldn't time out.

The problem is due to the code in and related to BugViewMixing.subscription_class, since this actually checks `if person in duplicate_subscribers`, which means iterating over all the subscribers from dupes.

We should add a pair of methods to IBug, userIsDirectSubscriber() and userIsSubscribedFromDuplicate() which do straight SQL lookups. This should save us from hitting the timeout, since most of the time is spent outside the database iterating over the subscribers list.

Related branches

lp:~gmb/launchpad/subscribers-timeout-bug-487015
Gavin Panella (community): Approve (code)
Diff: 395 lines (+188/-20)
7 files modified
lib/lp/bugs/browser/bug.py (+16/-1)
lib/lp/bugs/configure.zcml (+4/-1)
lib/lp/bugs/doc/bug.txt (+116/-16)
lib/lp/bugs/interfaces/bug.py (+18/-0)
lib/lp/bugs/model/bug.py (+32/-0)
lib/lp/bugs/templates/bug-portlet-subscribers-content.pt (+1/-1)
lib/lp/bugs/templates/bug-portlet-subscribers.pt (+1/-1)
Graham Binns (gmb)
Changed in malone:
status: Triaged → In Progress
Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r9944 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/revision/9944>

Changed in malone:
status: In Progress → Fix Committed
Graham Binns (gmb)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.