Every illegal character aren't well detected and forbidden

[Roumano]

Binary package hint: hugin

Ubuntu 9.10n hugin version 0.8.0 :

With some picture, i can load image on hugin but i can allign :

Hugin crash when i try to "allign" pictures :
 Pop-up error :
commande : autopano-complete --points 20 -o /tmp/ap_reskJ5efT "/home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.40 - L\\'île de Taquile.jpg" "/home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.49 - L\\'île de Taquile.jpg" "/home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.58 - L\\'île de Taquile.jpg" "/home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.58.06 - L\\'île de Taquile.jpg" "/home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.58.15 - L\\'île de Taquile.jpg" "/home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.58.23 - L\\'île de Taquile.jpg"
a échoué avec un code erreur : 1

On the command ligne, error :

MainFrame::RestoreLayoutOnNextResize()
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.40 - L'île de Taquile.jpg
CacheEntry: 2last access: 1 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.40 - L'île de Taquile.jpg
CacheEntry: 3last access: 2 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.40 - L'île de Taquile.jpg
CacheEntry: 3last access: 2 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.40 - L'île de Taquile.jpg
CacheEntry: 3last access: 3 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.40 - L'île de Taquile.jpg
CacheEntry: 3last access: 3 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.49 - L'île de Taquile.jpg
CacheEntry: 1last access: 4 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.40 - L'île de Taquile.jpg
CacheEntry: 3last access: 3 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.49 - L'île de Taquile.jpg
CacheEntry: 1last access: 4 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.58 - L'île de Taquile.jpg
CacheEntry: 1last access: 5 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.40 - L'île de Taquile.jpg
CacheEntry: 3last access: 3 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.49 - L'île de Taquile.jpg
CacheEntry: 1last access: 4 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.58 - L'île de Taquile.jpg
CacheEntry: 1last access: 5 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.58.06 - L'île de Taquile.jpg
CacheEntry: 1last access: 6 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.40 - L'île de Taquile.jpg
CacheEntry: 3last access: 3 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.49 - L'île de Taquile.jpg
CacheEntry: 1last access: 4 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.58 - L'île de Taquile.jpg
CacheEntry: 1last access: 5 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.58.06 - L'île de Taquile.jpg
CacheEntry: 1last access: 6 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.58.15 - L'île de Taquile.jpg
CacheEntry: 1last access: 7 8bit: 1 16bit: 1 float: 1 mask: 1
0x1c640d8: 20%
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.40 - L'île de Taquile.jpg
CacheEntry: 3last access: 3 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.49 - L'île de Taquile.jpg
CacheEntry: 1last access: 4 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.58 - L'île de Taquile.jpg
CacheEntry: 1last access: 5 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.58.06 - L'île de Taquile.jpg
CacheEntry: 1last access: 6 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.58.15 - L'île de Taquile.jpg
CacheEntry: 1last access: 7 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.58.23 - L'île de Taquile.jpg
CacheEntry: 1last access: 8 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.40 - L'île de Taquile.jpg
CacheEntry: 2last access: 3 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.49 - L'île de Taquile.jpg
CacheEntry: 2last access: 9 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.57.58 - L'île de Taquile.jpg
CacheEntry: 1last access: 5 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.58.06 - L'île de Taquile.jpg
CacheEntry: 1last access: 6 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.58.15 - L'île de Taquile.jpg
CacheEntry: 1last access: 7 8bit: 1 16bit: 1 float: 1 mask: 1
Image: /home/roumano/Images/2008 05 Perou/Panoramique/2008-05-11--09.58.23 - L'île de Taquile.jpg
CacheEntry: 1last access: 8 8bit: 1 16bit: 1 float: 1 mask: 1

If i rename the picture, to remove the ' , it's works ....

[Yuv (yuv)]

Known issue.

possibly fixed in the current development version (2009.3). Can you please install it from [1] and report if the issue is fixed?

thanks
Yuv

[0] http://wiki.panotools.org/Hugin_FAQ#Special_Characters_in_Paths
[1] https://launchpad.net/~hugin/+archive/nightly

[Thibault Lemaitre (thibault.lemaitre)]

I'm running Ubuntu 10.10 with the Hugin's version of the PPA hugin-builds (so the 2010.4.0) and that's not fixed.

I also try other special characters and I have some test result to give back to the developers in the attached file.

During my tests, a message opened when I used the characters =;:% and I had to find another name. In my opinion, this is really user-friendly and one way to fix this bug should be to add the special characters known to cause a bug to this list. This list should depend of the OS if the special character support depends of the OS used.

[Thibault Lemaitre (thibault.lemaitre)]

I try to find how to fix this bug and I have a patch to propose new forbidden special characters.

As the CVS are quite new for me, I explain the way I use here. If there is mistakes, told me.

I cloned the mercurial repository to my laptop, modified a file and compile Hugin after the modifications. I then try to save a panorama with the character I introduced and I get the message I expected to. I finally commit the modifications and export them to a patch that I attach to this message.

[tmodes (tmodes)]

Hi Thibault,

your patch does not work as intended.
* You changed the comment but did not understand what it states.
* Your patch breaks stitching on Windows, because every (locale) filename contains a :, which your patch rejects.
* Your patch rejects too much characters which works, e.g. ampersand, single quote. (some of them were fixed lately)

see also the other bug reports:
https://bugs.launchpad.net/hugin/+bug/679353
https://bugs.launchpad.net/hugin/+bug/737224

Committed changes which fixes some the characters in a more general way.

[Thibault Lemaitre (thibault.lemaitre)]

Ok.

Bad to learn that my patch is not good :(
But good to learn that more illegal characters are detected in the last versions :)

I will try it from the PPAs (nightly builds I suppose ?).

[Thibault Lemaitre (thibault.lemaitre)]

I test with the current version of the PPA (so version 2011.0.0.472072ea810d). I also looked the mercurial repo and see the last update (2c1006ce6919) which forbids the following for other OS than Windows (if I well understood):
=;:%*?<>|\"

My tests shows that I can use the followings
*'&
It was not possible to well use the following characters:
$~.
The point (.) seemed to well work but in fact the filename is cut and the extension is added after the first point encountered.

I attach some logs I had during these tests. That's only the log corresponding to the times where Hugin told me there was an error and stop to stitch.

To conclude, for me, the minimal forbidden characters on Linux are:
=;:%?<>|\"$~.

[Stefan Peter (s-peter-deactivatedaccount)]

Am 24.03.2011 19:50, schrieb Thibault Lemaitre:

> To conclude, for me, the minimal forbidden characters on Linux are:
> =;:%?<>|\"$~.

I would add ' and `

Regards

Stefan Peter

--
In theory there is no difference between theory and practice. In
practice there is.

[Thibault Lemaitre (thibault.lemaitre)]

I did some more tries with the same version than yesterday.

These characters worked for me
'`^"#!@

The escape character (\) didn't work

So the " should be authorized and the \ should be added to the forbidden characters.

For the ", I read on the mercurial repo that there was problem with :
"the double quote does not work with the panotools file format, so also reject"
So, somebody who knows more about that should test it more accurately.

[tmodes (tmodes)]

> I test with the current version of the PPA (so version
> 2011.0.0.472072ea810d). I also looked the mercurial
> repo and see the last update (2c1006ce6919)

What should that? The issues were fixed after 472072ea810d but you did test with the older version. This is not helpful.

The double quote does not work with the panotools file format. It is not polite that you state that other should more accurately test, if you don't know the code base and have only done some short tests.

[Thibault Lemaitre (thibault.lemaitre)]

tmodes, sorry for my English, but there is clearly a misunderstanding between us.

When I told :
"For the ", I read on the mercurial repo that there was problem with :
"the double quote does not work with the panotools file format, so also reject"
So, somebody who knows more about that should test it more accurately."
It meant that **my test** were really simple and somebody who have more knowledge in hugin should be able to better judge if the double quote cause really a problem or not (for example the person who write the comment about the double quote). I wrote it cause I hadn't problem with the " and didn't understand why it was forbidden. The simplicity of my tests can maybe explain that.

Concerning the version I choose to test. I used the nightly PPA cause the last time I compile hugin, it took much time : one more time, my test where maybe too simple.

[Yuv (yuv)]

On March 26, 2011 05:42:10 am Thibault Lemaitre wrote:
> tmodes, sorry for my English, but there is clearly a misunderstanding
> between us.

I understand French in case you need translation.

I have observed your "contribution" and am not pleased either. Dumping a
patch both in the mailing list and in this tracker is redundant and only
causes confusion.

http://groups.google.com/group/hugin-ptx/browse_thread/thread/135e3fa5646a88cc

[Thibault Lemaitre (thibault.lemaitre)]

I'm ok that the ways I used weren't the best one. Especially for the double submission I did (I didn't patient enough) and the quality of the patch that I proposed (which was completely false). Moreover, one of my comments weren't enough clear, and could be read as an insult to the coders, for sure!

Globally, I thought simply that things were easy for a newbie in development (that I am). I, now, think I'm clearly not enough involved in Hugin to be able to propose patches and well understand their impact. I will reserve my future "contributions" (if there are) to post comments and test results and translations (if necessary) and try to follow the feedback you give me with this bug to this in the better way.

However, I'm a little bit surprised to read only bad news about my tests of contribution. My tests or suggestions weren't complete, but if I read the changelog on the repo, it seems it helped a little bit. I don't need people told me thanks for such a little participation (of poor quality moreover), but when somebody take time to write a message, he can says thanks for the help it gives and then explain what wasn't good. I'm trying to participate in other open source projects (on which I also did some errors) and it's the first time that I have only pessimistic feedback.

I hope that my next participations in Hugin will be better for everyone.

[Yuv (yuv)]

Bonjour Thibault

I don't like to see you ending this participation with bad feelings. I understand that from your perspective you are making an effort to contribute, and you are using your valuable time for this. I tried to identify positives in your contribution and I must honestly say that the only thing I came up with is effort. And a lot of it.

If I may give you a feedback regarding this interaction, you need to be more patient and consider the effect of your efforts on others.

Please consider that it is not only your time, but also the time of those that read the reports and act on them. When you post the patch twice in two different places (mailing list and bug tracker), it is more work for us (two downloads, that must be compared to make sure that they are really the same, and if not to find out which one is the newer/right one).

Furthermore, when you write on the ML "I'm not on the ML, don't forget me in your eventual answers.", it puts the onus of not forgetting you on eventual replier. If you want a reply, it is up to you to make the effort to receive it; and if you send something to an ML, it is the minimum respect and courtesy for those whose time is used reading your post to go back to that ML and read their replies.

As far as testing is concerned, best practice is to use the latest repository version, or at least a version after the fix. If you can't build yourself, for whatever reason, wait until you can get a binary produced after the fix. If you relies on the nightlies, wait for a more recent nightly to be available. This may mean waiting a day or two. Or more if the nightlies-process is broken, as it sometimes happens, but it is important to respect the time of those reading the feedback. Feedback on a version prior to Thomas modification is a waste of time - yours and ours.

Ultimately, it seems to me that you lack patience. I did not look if you posted first on the bug tracker or first on the mailing list, but it seems to me that you did not wait for feedback and just re-posted. You did not wait for the change to propagate to the binary that you use for testing, resulting in testing against an obsolete binary that wasted the time of everybody involved - including you.

You are welcome to contribute again. Just learn to be patient and adapt to the project's pace and communication means. If you are not sure, ask (e.g. ask if a patch is better posted on the ML or in the BT).

Yuv