upstream bugs should not be polled on duplicate bug entries

Bug #484609 reported by Micah Gersten
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Graham Binns

Bug Description

Now that LP is pulling from bugzilla.mozilla.org since they upgraded to bugzilla 3.4.3, it seems that bugs marked as duplicates are also pulling comments from upstream. I do not think this is a good idea as it creates a log of bug mail unnecessarily as well as pulling duplicate information into LP.
--------------------------------------------------
https://bugs.launchpad.net/bugs/21202

*** This bug is a duplicate of bug 11334 ***
    https://bugs.launchpad.net/bugs/11334

Launchpad has imported 45 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=311340.

-----------------------------------------------

https://bugs.launchpad.net/bugs/106644

*** This bug is a duplicate of bug 11334 ***
    https://bugs.launchpad.net/bugs/11334

Launchpad has imported 45 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=311340.

------------------------------------------------------

https://bugs.launchpad.net/bugs/69613

*** This bug is a duplicate of bug 11334 ***
    https://bugs.launchpad.net/bugs/11334

Launchpad has imported 45 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=311340.

------------------------------------------------------

https://bugs.launchpad.net/bugs/11334

Launchpad has imported 45 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=311340.

Related branches

Revision history for this message
Graham Binns (gmb) wrote :

Agreed. That's actually pretty easy to fix. Here's what needs to happen (in case someone wants to take a crack at it before one of the Bugs team gets time):

In lib/lp/bugs/scripts/checkwatches.py the conditions on lines 780 and 782 should be updated to include the clause `and bug_watch.bug.duplicateof is None`. This will stop the importing and, more importantly, the pushing of comments from or to remote bugs where the Launchpad bug is a duplicate of another Launchpad bug.

The tests in lib/lp/bugs/doc/checkwatches.txt should be updated to include tests to cover this change.

Marking this as high; we need to fix this before we enable comment pushing for bugzilla.mozilla.org.

Changed in malone:
importance: Undecided → High
status: New → Triaged
milestone: none → 3.1.11
tags: added: bugwatch
Revision history for this message
Reed Loden (reed) wrote :

I had a few minutes today, so I decided to try to figure out how lp does branches and stuff, so I created a personal branch with the fix gmb mentioned in comment #1. However, I don't really understand the format of lib/lp/bugs/doc/checkwatches.txt, so not sure what I'm exactly supposed to add there. I was expecting an actual automated test, but it seems as it's just notes on some random stuff that bugwatches.py handles.

Revision history for this message
Graham Binns (gmb) wrote : Re: [Bug 484609] Re: upstream bugs should not be polled on duplicate bug entries

2009/11/18 Reed Loden <email address hidden>:
> I had a few minutes today, so I decided to try to figure out how lp does
> branches and stuff, so I created a personal branch with the fix gmb
> mentioned in comment #1. However, I don't really understand the format
> of lib/lp/bugs/doc/checkwatches.txt, so not sure what I'm exactly
> supposed to add there. I was expecting an actual automated test, but it
> seems as it's just notes on some random stuff that bugwatches.py
> handles.

It's actually a doctest, which means that it's testable documentation [1].

However, rather than go over the whole thing with you now I'll take a
look at the branch myself; it shouldn't take long to write the
requisite test and I've got some spare time before my EOD.

Thanks for providing the fix!

 [1] http://docs.python.org/library/doctest.html

Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit
Changed in malone:
status: Triaged → Fix Committed
Gavin Panella (allenap)
Changed in malone:
assignee: nobody → Graham Binns (gmb)
Graham Binns (gmb)
Changed in malone:
status: Fix Committed → Fix Released
Revision history for this message
Przemek K. (azrael) wrote :

Also these imported comments create confusion because they link to local bug numbers instead of upstream duplicates.
Example: Bug #263435
" In Mozilla Bugzilla #78414, Bugzilla-iwaruna (bugzilla-iwaruna) wrote on 2001-11-27: #13

*** Bug 112299 has been marked as a duplicate of this bug. *** "

The above quoted comment is about Mozilla bug 112299, but the text "bug 112299" links to the same bug number in Launchpad.

Revision history for this message
Graham Binns (gmb) wrote : Re: [Bug 484609] Re: upstream bugs should not be polled on duplicate bug entries

2010/1/10 Przemysław Kulczycki <email address hidden>:
> Also these imported comments create confusion because they link to local bug numbers instead of upstream duplicates.

This is a separate bug. Please help us out by filing it at
https://bugs.launchpad.net/malone/+filebug

Revision history for this message
Przemek K. (azrael) wrote :

2010/1/10 Graham Binns <email address hidden>:
> 2010/1/10 Przemysław Kulczycki <email address hidden>:
>> Also these imported comments create confusion because they link to local bug numbers instead of upstream duplicates.
>
> This is a separate bug. Please help us out by filing it at
> https://bugs.launchpad.net/malone/+filebug

Ok.
Bug #505760 filed.

--
## Przemysław Kulczycki <<=>> Azrael Nightwalker ##
# Jabber/XMPP/Gtalk/Tlen ID: azrael[na]jabster.pl #
# (Co to jest? Zobacz na: http://jabberfaq.info ) #
## www: http://reksio.ftj.agh.edu.pl/~azrael/ #####

Revision history for this message
Graham Binns (gmb) wrote :

2010/1/11 Przemysław Kulczycki <email address hidden>:
>> This is a separate bug. Please help us out by filing it at
>> https://bugs.launchpad.net/malone/+filebug
>
> Ok.
> Bug #505760 filed.

Excellent, thank you.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.