libsidplay2 is playing certain sidtunes too fast

[kalasmannen]

Binary package hint: libsidplay2

When installing Xmms-sid, libsidplay1 and 2 from apt, when using libsidplay2 to play sidtunes, it plays some tunes twice as fast. I was told this was a bug with libsidplay2. When built with gcc4 this occours.

[Teemu Likonen (dtw)]

I can confirm this with sidplay2 command line player (in package sidplay). Songs play about 1.3-1.5 times too fast no matter what options I try. XSidplay which uses libsidplay1 plays songs correctly. This bug has been around a long time and upstream's "latest informations" are two years old <http://sidplay2.sourceforge.net/>. Sad...

[Oliver Klee (launchpad-oliverklee)]

I can confirm this on Dapper with sidplay (using libsidplay2), too.

[kalasmannen (kalasmannen)]

I've tried to compile libsidplay2 myslef, without success, however, on FreeBSD wich uses an older version of Gcc (3 something i think), it works and plays all tunes in the correct speed. This is probably true to all systems with a version of gcc prior to gcc 4.

[Adric Riedel (adric-riedel)]

Also confirmed. It seems to be playing ALL tunes at the CIA timer frequency, ignoring the file attributes. The bug would be less noticeable if more than a fraction of tunes were INTENDED to use the CIA timer...

As per my other bug (https://launchpad.net/distros/ubuntu/+source/sidplay-libs/+bug/32983), Gentoo has a patch in Portage to fix what appears to be bad C++ syntax in the speed selector, that's no longer valid in GCC 4.1... but when I tried applying it in Ubuntu it didn't actually work.

[Adric Riedel (adric-riedel)]

Attached is a bz2ball with a working libsidplay2.so. It works on my machine (TM).

(Xubuntu 6.06, all the latest updates as of 20061005 and Ubuntu's libsidplay2 already installed on the machine. I just dropped in the files, and everything works now. Maybe I'm just lucky?)

It was compiled with GCC 4.1 and march=pentium2 on the Gentoo box I've mentioned.

[Adric Riedel (adric-riedel)]

And now the actual important part, here's the patch ( to the plain sidplay-libs-2.1.1 code?) that apparently makes the above work.

I apologize for my unorthodox (and probably incorrect) way of obtaining and submitting this patch... I hope this works.

[kalasmannen (kalasmannen)]

Great! The patch fixes the issue, it's confirmed. Loads of thanks to you, Adric! :)

[Adric Riedel (adric-riedel)]

Given that this packages' maintainer, Mr. Boszormenyi, is a Debian developer (this is an auto-synched package) I've sumitted the patch to the Sidplay2 sourceforge page, where it turns out someone named GCS (apparently Boszormenyi) filed a bug on this about a year ago. If it gets applied, EVERYONE can benefit on all distros.

[Adric Riedel (adric-riedel)]

I've reported the bug and the patch to the upstream maintainer (Simon White) who says he'll include it, and is waiting for someone else's ALSA patches before releasing a new version...

And now I have a new question: kalasmannen, how did you get the patch to work? I tried applying it to a stock sidplay-libs and compiling it manually on Ubuntu, and ended up with songs being played too fast again. (which is odd, but I'm lead to believe that *should* work)

[kalasmannen (kalasmannen)]

I just applied it to the source like regular i think.. It was a while ago now, but after applying it i was able to build a working version. :)

[Emmet Hikory (persia)]

This issue was fixed in edgy with the upload of 2.1.1-5 (due to previous fix in 2.1.1-4, which version was never released in Ubuntu).