Revamp GUI playlist code

Bug #483930 reported by reacocard
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Medium
reacocard

Bug Description

The code in xlgui/playlist.py:Playlist is a bit of a mess wrt how it handles updates and its internal playlist object. Ideally, this should be implemented as a pure MVC model using the internal Playlist for the model, and with the gui playlist's methods serving as part of either the view or control on top. For example, currently, changes to the set of displayed tracks are taken care of purely in the gui code, in several different spots, some of which react partially to changes on the backend. Ideally, this would be rewritten so control methods like DnD just change the backend, and then the events sent by the backend are reacted to be the view methods. This may require adding some events to the backend playlist. (consider porting backend playlist to use gobject signals at the same time.)

Revision history for this message
Adam Olsen (arolsen) wrote :

I think we should either convert all out to gobject signals or keep using the custom event model in the non-gui code. At least now there's some semblance of a reason for the old event system, porting the backend to gobject signals will remove even that.

Revision history for this message
reacocard (reacocard) wrote :
Changed in exaile:
assignee: nobody → Aren Olson (reacocard)
milestone: none → 0.3.3
status: Confirmed → In Progress
Mathias Brodala (mathbr)
summary: - gui playlist code is a bloody mess
+ Revamp GUI playlist code
Revision history for this message
reacocard (reacocard) wrote :

This has been in trunk for a while now.

Changed in exaile:
status: In Progress → Fix Committed
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.