--null option not supported

Bug #482919 reported by Gordon Tyler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bzr-xmloutput
Fix Released
Medium
Guillermo Gonzalez

Bug Description

The help for each of the xml commands says that it supports the --null option but they either silently ignore it or produce an error.

For example:

C:\Temp\bzr>bzr xmlls --null
<?xml version="1.0" encoding="cp1252"?><?xml version="1.0" encoding="cp1252"?><e
rror><class>TypeError</class><dict></dict><message>show_ls_xml() got an unexpect
ed keyword argument 'null'</message></error>

Should these commands support the --null option or is it just an copy&paste bug from the original non-xml commands help?

Related branches

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Thanks for reporting this.

All the commands have a --null option and I think they should support it, I'll try to propose a fix ASAP.

Thanks

Changed in bzr-xmloutput:
status: New → Triaged
importance: Undecided → Medium
milestone: none → 0.8.6
Revision history for this message
Gordon Tyler (doxxx) wrote :

From what I understand of the --null option in the standard bzr commands, it doesn't really make sense for the xml commands. In the standard commands it's used as a field separator to make it easier to parse, right? That's already accomplished for the xml commands by the fact that the output is in xml.

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Hi Gordon,

Yes, it doesn't make sense from the XML POV, but I think this was requested by a developer working on Anjuta (or other IDE, I cant' find the irc chat) as he was using bzr-xmloutput from CLI and the too he was using required a null terminated string as the output of the command.

But I agree that this isn't requried for the common use case.

Thanks!

Changed in bzr-xmloutput:
milestone: 0.8.6 → 0.8.7
Changed in bzr-xmloutput:
status: Triaged → In Progress
Changed in bzr-xmloutput:
assignee: nobody → Guillermo Gonzalez (verterok)
status: In Progress → Fix Committed
Changed in bzr-xmloutput:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.