Launchpad itself

Should be possible to add a member without leaving a team's main page

Bug #482176 reported by Guilherme Salgado
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Edwin Grubbs
Launchpad itself 10.01

Bug Description

We should provide an ajaxy form to add a new team member from the team's main page.

Tags: lp-registry

Related branches

lp:~salgado/launchpad/ajax-add-member
lp:~edwin-grubbs/launchpad/bug-482176-add-team-member-ajax-part2
Martin Albisetti (community): Approve (ui)
Curtis Hovey (community): Approve (code and js)
Guilherme Salgado (community): Needs Fixing
Canonical Launchpad Engineering: Pending (code ui) requested
Diff: 962 lines (+399/-202)
16 files modified
lib/canonical/launchpad/icing/style-3-0.css (+3/-0)
lib/canonical/launchpad/icing/style.css (+0/-2)
lib/canonical/launchpad/javascript/code/codereview.js (+7/-6)
lib/canonical/launchpad/javascript/lp/errors.js (+33/-3)
lib/canonical/launchpad/javascript/registry/team.js (+83/-49)
lib/lp/registry/browser/person.py (+33/-21)
lib/lp/registry/browser/tests/mailinglist-views.txt (+5/-4)
lib/lp/registry/interfaces/person.py (+27/-17)
lib/lp/registry/model/person.py (+8/-5)
lib/lp/registry/model/teammembership.py (+2/-10)
lib/lp/registry/stories/team/xx-team-home.txt (+21/-10)
lib/lp/registry/stories/team/xx-team-membership.txt (+13/-0)
lib/lp/registry/templates/team-index.pt (+1/-1)
lib/lp/registry/templates/team-members.pt (+53/-51)
lib/lp/registry/templates/team-portlet-membership.pt (+36/-23)
lib/lp/registry/windmill/tests/test_team_index.py (+74/-0)
lp:~edwin-grubbs/launchpad/bug-482176-add-team-member-ajax-part1
Gavin Panella (community): Approve (code)
Diff: 830 lines (+294/-82)
17 files modified
lib/canonical/launchpad/javascript/bugs/bugtask-index.js (+4/-37)
lib/canonical/launchpad/javascript/code/codereview.js (+9/-1)
lib/canonical/launchpad/javascript/lp/picker.js (+5/-2)
lib/canonical/launchpad/javascript/registry/team.js (+102/-0)
lib/lp/app/templates/base-layout-macros.pt (+2/-0)
lib/lp/bugs/tests/test_bugs_webservice.py (+0/-10)
lib/lp/registry/browser/configure.zcml (+3/-0)
lib/lp/registry/browser/person.py (+43/-12)
lib/lp/registry/browser/tests/teammembership-views.txt (+1/-0)
lib/lp/registry/browser/tests/test_person_webservice.py (+38/-0)
lib/lp/registry/doc/teammembership-email-notification.txt (+6/-0)
lib/lp/registry/doc/teammembership.txt (+39/-2)
lib/lp/registry/interfaces/teammembership.py (+2/-0)
lib/lp/registry/model/person.py (+3/-1)
lib/lp/registry/model/teammembership.py (+4/-5)
lib/lp/registry/templates/team-index.pt (+10/-0)
lib/lp/registry/templates/team-portlet-membership.pt (+23/-12)
lp:~edwin-grubbs/launchpad/bug-482176-add-team-member-ajax-part3
Aaron Bentley (community): Approve (code)
Diff: 1635 lines (+279/-220)
57 files modified
lib/canonical/launchpad/pagetests/standalone/xx-beta-testers-redirection.txt (+1/-1)
lib/lp/answers/doc/person.txt (+2/-2)
lib/lp/bugs/browser/tests/bug-views.txt (+1/-1)
lib/lp/bugs/doc/bugnotification-comment-syncing-team.txt (+1/-1)
lib/lp/bugs/doc/bugnotification-sending.txt (+4/-2)
lib/lp/bugs/doc/bugtask.txt (+2/-1)
lib/lp/bugs/stories/bugwatches/xx-bugwatch-comments.txt (+1/-1)
lib/lp/code/stories/branches/xx-branch-deletion.txt (+1/-1)
lib/lp/code/stories/feeds/xx-revision-atom.txt (+1/-1)
lib/lp/registry/browser/team.py (+5/-3)
lib/lp/registry/browser/tests/peoplemerge-views.txt (+1/-1)
lib/lp/registry/browser/tests/person-views.txt (+1/-1)
lib/lp/registry/browser/tests/product-views.txt (+1/-1)
lib/lp/registry/browser/tests/projectgroupset-views.txt (+1/-1)
lib/lp/registry/browser/tests/team-views.txt (+4/-4)
lib/lp/registry/browser/tests/teammembership-views.txt (+1/-2)
lib/lp/registry/doc/announcement.txt (+1/-1)
lib/lp/registry/doc/commercialsubscription.txt (+1/-1)
lib/lp/registry/doc/mailinglist-email-notification.txt (+8/-5)
lib/lp/registry/doc/mailinglist-subscriptions.txt (+3/-3)
lib/lp/registry/doc/mailinglists.txt (+2/-1)
lib/lp/registry/doc/person-merge.txt (+3/-3)
lib/lp/registry/doc/person.txt (+2/-2)
lib/lp/registry/doc/private-team-visibility.txt (+3/-3)
lib/lp/registry/doc/teammembership-email-notification.txt (+7/-12)
lib/lp/registry/doc/teammembership.txt (+100/-63)
lib/lp/registry/doc/vocabularies.txt (+2/-3)
lib/lp/registry/stories/mailinglists/lifecycle.txt (+1/-1)
lib/lp/registry/stories/mailinglists/subscriptions.txt (+3/-3)
lib/lp/registry/stories/person/xx-admin-person-review.txt (+2/-1)
lib/lp/registry/stories/product/xx-product-edit.txt (+1/-1)
lib/lp/registry/stories/product/xx-productset.txt (+1/-1)
lib/lp/registry/stories/team/xx-team-add-my-teams.txt (+40/-38)
lib/lp/registry/stories/teammembership/20-managing-members.txt (+14/-5)
lib/lp/registry/stories/teammembership/private-team.txt (+1/-1)
lib/lp/registry/stories/teammembership/xx-add-member.txt (+15/-12)
lib/lp/registry/stories/teammembership/xx-expire-subscription.txt (+1/-1)
lib/lp/registry/stories/teammembership/xx-member-renewed-membership.txt (+1/-1)
lib/lp/registry/stories/teammembership/xx-private-membership.txt (+4/-4)
lib/lp/registry/stories/vouchers/xx-voucher-redemption.txt (+2/-1)
lib/lp/registry/stories/webservice/xx-private-membership.txt (+4/-3)
lib/lp/registry/stories/webservice/xx-source-package.txt (+1/-1)
lib/lp/registry/stories/webservice/xx-structuralsubscription.txt (+1/-1)
lib/lp/registry/tests/bug-249185.txt (+5/-4)
lib/lp/registry/tests/test_teammembership.py (+4/-4)
lib/lp/soyuz/browser/tests/archive-views.txt (+2/-2)
lib/lp/soyuz/browser/tests/build-views.txt (+1/-1)
lib/lp/soyuz/doc/archive.txt (+3/-2)
lib/lp/soyuz/doc/archivepermission.txt (+1/-1)
lib/lp/soyuz/doc/archivesubscriber.txt (+2/-1)
lib/lp/soyuz/doc/build-notification.txt (+1/-1)
lib/lp/soyuz/doc/build.txt (+3/-3)
lib/lp/soyuz/doc/distroseriesqueue-dist-upgrader.txt (+1/-1)
lib/lp/soyuz/doc/packageset.txt (+1/-1)
lib/lp/soyuz/stories/ppa/xx-private-ppa-subscription-stories.txt (+1/-1)
lib/lp/soyuz/stories/soyuz/xx-private-builds.txt (+1/-1)
lib/lp/translations/stories/standalone/xx-sourcepackage-export.txt (+1/-1)
Revision history for this message
Guilherme Salgado (salgado) wrote :

I've started this during the lazr-js sprint and it only needs some polishing now, but I'm not sure when I'll have time to finish.

Changed in launchpad-registry:
status: Triaged → In Progress
Curtis Hovey (sinzui)
Changed in launchpad-registry:
importance: Undecided → High
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: none → 3.1.11
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: 3.1.11 → 3.1.12
Curtis Hovey (sinzui)
Changed in launchpad-registry:
assignee: Guilherme Salgado (salgado) → nobody
Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Edwin.

Can you take a look at this and estimate the time needs to complete this branch. I do not want to commit to fixing this for 3.1.12 if it will take you a week.

Changed in launchpad-registry:
assignee: nobody → Edwin Grubbs (edwin-grubbs)
Edwin Grubbs (edwin-grubbs)
Changed in launchpad-registry:
status: In Progress → Triaged
Revision history for this message
Curtis Hovey (sinzui) wrote :

I am moving this to the next milestone because this feature will not be on edge long enough to get user feedback to refine the feature.

Changed in launchpad-registry:
assignee: Edwin Grubbs (edwin-grubbs) → nobody
milestone: 3.1.12 → 3.1.13
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Salgado's branch has all the basic functionality. The following changes should be made before it lands, which should only take two days to complete.

 * Move certain <script> tags to the base-layout-macros.pt
 * Prevent the "Add member" link from creating a new picker widget each time it's clicked.
 * Add a windmill test.
 * An error is displayed currently if you try to add a team as a member. This should be changed to add the team to the Pending Approval list instead of the Latest Members list if the user is not the owner of the other team also.
 * The "Add member" link on the +members should be ajaxified like the +index page's link.
 * Check if the error reporting widget is ready to be used.

Additional changes that would be nice but will take longer:
 * The picker should show already subscribed members already grayed out with an explanation, so the user knows the search worked, but can't trigger an error by selecting that person.
 * Add an ajax remove button next to each member's name in the list on both the +index and +members pages. Alternatively, the +index page could point to the page for editing the membership duration, etc. like the +members page does, and we could use form-overlay for that form.

Separate issue:
 * The "Add one of my teams" link should be hidden if the user is not allowed to use that page.

Edwin Grubbs (edwin-grubbs)
Changed in launchpad-registry:
assignee: nobody → Edwin Grubbs (edwin-grubbs)
Edwin Grubbs (edwin-grubbs)
Changed in launchpad-registry:
status: Triaged → In Progress
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote : Bug fixed by a commit

Fixed in devel r10111 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/revision/10111>

Changed in launchpad-registry:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.