qadd: "select all" does not work

Bug #480688 reported by IWATA Hidetaka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
High
Gary van der Merwe

Bug Description

At qbzr 0.16.0, "select all" in qadd dialog does not work.
No file is selected after checking "Select / deselect all".

It seems like same behavior as qcommit. ("Select all" in qcommit dialog ignores unversioned files)

Bzr version: 2.0.0
Qbzr version: 0.16.0
Platform: Windows-XP-SP3
PyQt version: 4.5.4

Related branches

Revision history for this message
Alexander Belchenko (bialix) wrote :

I can't reproduce this with 0.16 or current trunk on Windows XP + bzr 2.0.2 + PyQt 4.4.3 (bzr.exe)

Is it PyQt 4.5-specific bug?

Can try to install bzr.exe 2.0.2 and check again?

Changed in qbzr:
status: New → Incomplete
Revision history for this message
IWATA Hidetaka (hid-iwata) wrote :

I tried and it is reproduced with bzr 2.0.2 too.

I checked again under some conditions, and I found that
* unversioned files/folders in the branch root -> OK
* unversioned files/folders in the versioned folder -> NG
* unversioned files/folders in the unversioned folder -> OK (Only if all intermediate folders are unversioned)

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 480688] Re: qadd: "select all" does not work

iwata пишет:
> I tried and it is reproduced with bzr 2.0.2 too.
>
> I checked again under some conditions, and I found that
> * unversioned files/folders in the branch root -> OK
> * unversioned files/folders in the versioned folder -> NG

Still can't reproduce. It's working for me with current trunk.

C:\Temp>bzr init 3
Created a standalone tree (format: pack-0.92)

C:\Temp\3>bzr mkdir foo
added foo

C:\Temp\3>echo bar > foo/bar

C:\Temp\3>bzr qadd
adding foo/bar

C:\Temp\3\foo>echo spam > spam

C:\Temp\3>bzr qadd
adding foo/spam

At any run of qadd I have correct behavior.

> * unversioned files/folders in the unversioned folder -> OK (Only if all intermediate folders are unversioned)
>

Revision history for this message
Gary van der Merwe (garyvdm) wrote :

To reproduce, use the steps above, but after mkdir foo, add foo.

Changed in qbzr:
assignee: nobody → Gary van der Merwe (garyvdm)
importance: Undecided → High
milestone: none → 0.17
status: Incomplete → Fix Released
Revision history for this message
IWATA Hidetaka (hid-iwata) wrote :

> C:\Temp>bzr init 3
> C:\Temp\3>bzr mkdir foo
> C:\Temp\3>echo bar > foo/bar
> C:\Temp\3>bzr qadd
> C:\Temp\3\foo>echo spam > spam
> C:\Temp\3>bzr qadd

These steps work normally in my environment, too... There may be more conditions to reproduce.

This probrem seems to be similar as #418520.
When probrem occurred, this message was displayed in console.
> QTreeView::rowsInserted internal representation of the model has been corrupted, resetting.
And file list was displayed in qadd dialog as tree, not flat. (see atachment.)

I'll check difference bitween OK case and NG case more closely.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.