Unfavourable namespaces in common.js

Bug #480631 reported by JaiBee
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Easy Menu
Invalid
Undecided
JaiBee

Bug Description

Hello,

the extension ubuntuusers Menu (generated with Easy Menu) was not released by Mozilla for this reason:

> Review Information:
> Reviewer: Brian King
> Tested on Mac OSX 10.5.8 with Firefox 3.5.4
> Comments: I'm going to reject this one because in common.js you have new variables called 'Prefs' and 'Overlay'. These are too general and there is a high probability of clashing. Please wrap them in a unique namespace for the next release.
>
> You can see an example of how to do this @ http://blogger.ziesemer.com/2007/10/respecting-javascript-global-namespace.html.

Can you please fix that?

Thanks a lot and best regards,
JaiBee

Revision history for this message
JaiBee (jaibee) wrote :

Sorry, my fault. It does not have anything to do with Easy Menu! The problem is caused by this code:
https://developer.mozilla.org/en/Code_snippets/On_page_load#Running_code_on_an_extension%27s_first_run_or_after_an_extension%27s_update

Changed in easymenu:
status: New → Invalid
assignee: nobody → JaiBee (jaibee)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.