canonical_url in lp.code.windmill.testing is bad bad bad bad bad bad bad

Bug #480137 reported by Paul Hummer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Paul Hummer

Bug Description

There's a wrapper implementation of canonical_url in lp.code.windmill.testing that helps us translate canonical_url urls to usable windmill urls, because they needed a port number. This was a necessary evil when Aaron landed it, and I reviewed it. However, there's a better way to do it by making some changes to the test layer to tell canonical_url about the port number.

I'm actually working on this right now, and should have a fix soon.

Tags: lp-code

Related branches

Paul Hummer (rockstar)
Changed in launchpad-code:
importance: Undecided → High
assignee: nobody → Paul Hummer (rockstar)
status: New → In Progress
milestone: none → 3.1.11
Tim Penhey (thumper)
Changed in launchpad-code:
milestone: 3.1.11 → 3.1.13
Curtis Hovey (sinzui)
Changed in launchpad-code:
milestone: 3.1.13 → 10.01
Revision history for this message
Paul Hummer (rockstar) wrote :

This is cooking in ec2 right now.

Revision history for this message
Paul Hummer (rockstar) wrote :

Fixed in revno 10163.

Changed in launchpad-code:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.