[lp:~zeitgeist/zeitgeist/zeitgeist-resonance] move code to compare two event/subject objects to the actual Event/Subject class

Bug #479985 reported by Markus Korn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zeitgeist Framework
Fix Released
Medium
Seif Lotfy

Bug Description

"test/resonance-engine-test.py" has some code to check if two Event objects are the same. This code should not stay in the testcase, but should be in the Event/Subject class, as this code is useful in other places

Revision history for this message
Siegfried Gevatter (rainct) wrote :

I think this is done now?

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

I added code to check if a given Event matches some tempalte event. We'll need that for notifications and bklacklisting. We don't have a method to check for strict equality though afaik...

Seif Lotfy (seif)
Changed in zeitgeist:
assignee: nobody → Seif Lotfy (seif)
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Seif Lotfy (seif) wrote :

As far as i can see its already in the Event and Subject classes now
I dont think we need a strict comparsion if we use wildcards -.-

Revision history for this message
Siegfried Gevatter (rainct) wrote :

I am closing this assuming it is fixed.

Changed in zeitgeist:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.