Retrieving an Archive:EntryResource causes excessive repeated database queries
Bug #474876 reported by
James Westby
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Muharem Hrnjadovic |
Bug Description
The changes_file_url property of a SourcePackagePu
expensive to compute. It calls getChangesFiles
that it has to query for SourcePackagePu
joins. This can add up as you loop over the publications.
Please either make it less expensive to compute, or export it as a method,
rather than a property.
Thanks,
James
Related branches
lp:~al-maisan/launchpad/changes-url-474876
- Gavin Panella (community): Approve
-
Diff: 714 lines (+180/-99)5 files modifiedlib/lp/soyuz/doc/publishing.txt (+117/-78)
lib/lp/soyuz/interfaces/publishing.py (+16/-6)
lib/lp/soyuz/model/publishing.py (+30/-14)
lib/lp/soyuz/stories/webservice/xx-source-package-publishing.txt (+4/-1)
lib/lp/soyuz/tests/test_publishing_models.py (+13/-0)
summary: |
- getPublishedSources can timeout due to getChangesFilesForSources + Retrieving an Archive:EntryResource causes excessive repeated database + queries |
Changed in soyuz: | |
status: | Incomplete → Triaged |
importance: | Undecided → High |
tags: | added: api oops |
Changed in soyuz: | |
milestone: | none → 3.1.11 |
Changed in soyuz: | |
milestone: | 3.1.11 → 3.1.12 |
Changed in soyuz: | |
assignee: | nobody → Muharem Hrnjadovic (al-maisan) |
Changed in soyuz: | |
status: | Triaged → In Progress |
Changed in soyuz: | |
milestone: | 3.1.12 → 10.01 |
Changed in soyuz: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
OOPS 1404D3213 by the way.