import-dsc fails on UTF-8 characters

[Nicolas Valcarcel]

aborting commit write group: UnicodeDecodeError('ascii', 'Nicolas Valc\xc3\xa1rcel Scerpella (Canonical) <email address hidden>', 12, 13, 'ordinal not in range(128)')
bzr: ERROR: exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 12: ordinal not in range(128)

 Traceback (most recent call last):
   File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 842, in exception_to_return_code
     return the_callable(*args, **kwargs)
   File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 1037, in run_bzr
     ret = run(*run_argv)
   File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 654, in run_argv_aliases
     return self.run(**all_cmd_args)
   File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/builddeb/cmds.py", line 738, in run
     self.import_many(db, files_list, orig_target)
   File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/builddeb/cmds.py", line 681, in import_many
     db.import_package(os.path.join(orig_target, filename))
   File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/builddeb/import_dsc.py", line 1537, in import_package
     timestamp=timestamp, author=author)
   File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/builddeb/import_dsc.py", line 1416, in _do_import_package
     timestamp=timestamp, author=author)
   File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/builddeb/import_dsc.py", line 1141, in import_upstream
     revprops=revprops, timestamp=timestamp, timezone=timezone)
   File "/usr/lib/python2.6/dist-packages/bzrlib/workingtree_4.py", line 197, in commit
     result = WorkingTree3.commit(self, message, revprops, *args, **kwargs)
   File "/usr/lib/python2.6/dist-packages/bzrlib/mutabletree.py", line 229, in commit
     *args, **kwargs)
   File "/usr/lib/python2.6/dist-packages/bzrlib/commit.py", line 375, in commit
     self.rev_id = self.builder.commit(self.message)
   File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 174, in commit
     self.new_inventory, self._config)
   File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 1115, in add_revision
     self._add_revision(rev)
   File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 1118, in _add_revision
     text = self._serializer.write_revision_to_string(revision)
   File "/usr/lib/python2.6/dist-packages/bzrlib/chk_serializer.py", line 82, in write_revision_to_string
     revprops[key] = encode_utf8(value)[0]
 UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 12: ordinal not in range(128)

summary: bad data in a revision element such as message, revision id or author.

[Nicolas Valcarcel (nvalcarcel)]

Crash

[Robert Collins (lifeless)]

Is this repeatable Nicolas?

[Robert Collins (lifeless)]

oops nvm that question, clearly its your email address being non-ascii.

[Robert Collins (lifeless)]

Probably something serialising too early, or taking untrusted data and not decoding it.

[Nicolas Valcarcel (nvalcarcel)]

As far as i checked when found this, the problem was that it readed my name, saw that it isn't ascii, treat it like a UTF-8 and forget about it, then it get's re-used by main bzr code, which sees a normal ascii string (or what it seems to) treat it like ascii, and then find that there is a horrible non-understandable character, then crashes. It was long ago so the details may be wrong, but i remember it was something like that.