Can't view branch/repository in the root of drive/filesystem

Bug #471097 reported by Adam Glauser
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Explorer
Fix Released
Medium
Ian Clatworthy

Bug Description

Steps to recreate:

bzr init-repo C:/
bzr init C:/devel
bzr explore C:/devel

Using BZR_PDB I can see that explorer crashed because it tried to work with URL like this: "file:///C:" which is incorrect because it lacks trailing slash.

So, locations.py: display_name() uses .rstrip('/') for all URLs which is wrong thing is branch or repo resides in the root of the drive, either on Windows or Linux.

Related branches

Revision history for this message
Adam Glauser (adamglauser) wrote :
description: updated
Revision history for this message
Alexander Belchenko (bialix) wrote :

What URL exactly are you using when get this error?

What it means: "Map a network drive to a shared repository directory (can be on \\localhost)"?

Changed in bzr-explorer:
status: New → Incomplete
Revision history for this message
Adam Glauser (adamglauser) wrote :

I am not using a URL directly, but browsing to the mapped drive.

To be more clear, "Map a network drive to a shared repository directory (can be on \\localhost)" means to set a drive letter to refer to a network location, as in:
net use Z: \\servername\sharename

See attachment 'mapDriveSteps.txt' for a full example.

Revision history for this message
Adam Glauser (adamglauser) wrote :

FWIW, this is still happening in bzrExplorer 0.11.0dev (revision 351)
see attachment for updated stack trace.

Revision history for this message
Alexander Belchenko (bialix) wrote :

It's unrelated to mapped drive, and can be reproduced even on C: drive.

To reproduce:

bzr init-repo C:/
bzr init C:/devel
bzr explore C:/devel

Using BZR_PDB I can see that explorer crashed because it tried to work with URL like this: "file:///C:" which is incorrect because it lacks trailing slash.

Changed in bzr-explorer:
importance: Undecided → Medium
status: Incomplete → Confirmed
Revision history for this message
Alexander Belchenko (bialix) wrote :

So, locations.py: display_name() uses .rstrip('/') for all URLs which is wrong thing is branch or repo resides in the root of the drive, either on Windows or Linux.

Revision history for this message
Alexander Belchenko (bialix) wrote :

Workaround: don't put the repo/branch in the root of the filesystem until this bug will be fixed.

summary: - Can't view repository on network drive
+ Can't view branch/repository in the root of drive/filesystem
description: updated
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

Please test rev 416 and close this bug if everything is working now as expected now

Changed in bzr-explorer:
assignee: nobody → Ian Clatworthy (ian-clatworthy)
milestone: none → 1.0.0beta
status: Confirmed → Fix Committed
Revision history for this message
Alexander Belchenko (bialix) wrote :

It does not crash now, but branch opened has the tab with label: "devel []". I think it should be at least "devel [/]" if not "devel [C:/]". But the original bug is fixed. It's just UI thing.

Changed in bzr-explorer:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.