[users-admin] Modifying user has no effect

[bonde]

Binary package hint: gnome-system-tools

I'm on a fresh Ubuntu 9.10 install with gnome-system-tools version 2.28.1-0ubuntu2.

When using the gui for changing a users shell the changes will not be saved.

Steps to reproduce (or what I did):

1. System->Administration->Users and Groups
2. Click the key with the text "Click to make changes"
3. Select a user and click 'Preferences'
4. In the 'Advanced'-tab change the shell to '/usr/bin/zsh'
5. Press 'OK', log out and log back in.

Expected result:
When opening a terminal the $SHELL would be 'zsh'

Actual results:
The $SHELL was bash. The changes had not been saved.

You can also just press 'OK', and press 'Close' in the master window. When you edit the user again, the shell setting have changed.

In Jaunty I think this worked correctly.

[Milan Bouchet-Valat (nalimilan)]

Thanks for your report. I think your problem is the same as bug 463353, but applied to another operation. You can try the patch there to fix it.

[Milan Bouchet-Valat (nalimilan)]

It seems that bug 463353 is more complex than that, so I'm going to make it separate.

Please apply the attached patch using
sudo patch /usr/share/system-tools-backends-2.0/scripts/Users/Users.pm < [PATH TO FILE]
and report if that fixes the issue for you. Thanks!

[bonde (ulrikbonde)]

The patch works for me, thanks!

There's still a slight problem. The drop-down box with the available shells only shows '/bin/bash' though the file /etc/shells correctly lists all the shells. Seems like the file /usr/share/system-tools-backends-2.0/scripts/Users/Shells.pm should grab the shells from /etc/shells but that's not happening.

But you can now change the shells with the gui at least.

[Milan Bouchet-Valat (nalimilan)]

OK, renaming the bug then. Could you open a new report about the shells list problem? I'd like to track it separately before I forget about it.

[Milan Bouchet-Valat (nalimilan)]

Rationale for SRU:
- changing settings of an existing user always fails, so this leaves Karmic without GUI to do that
- this fix merely fixes a typo where a non-existent variable was used
- already applied upstream in the same form, should be available in 2.8.3

[bonde (ulrikbonde)]

I'll open a new bug about the listing of shells.