bzr commit with a file-lists commits the deletion of all missing files.

[James Troup]

When I tried to commit just changes in an individal directory, deletions from other directories were commited at the same time. doing a commit with a list of '.' in a subdir:

| ~/dak/debian-archive-kit/templates % bzr commit -m "Convert away from silly names" .
| modified templates/README
| renamed templates/override.bug-close
[ ... ]
| renamed templates/security-install.advisory
| deleted docs/.cvsignore
| deleted docs/README.names
| deleted docs/README.suite-removal
| deleted .cvsignore
| Committed revision 853.
| ~/dak/debian-archive-kit/templates %

[Robert Collins (lifeless)]

this is related to the current design defect where deletions happy magically, but is in fact a separate bug. The fault lies in Commit._remove_deleted not honouring the selected-files list in its decision to perform a heuristic-delete.

[Dato Simó (dato)]

I sent the following test case to the list, and I was asked to please
send it here as well:

----------------------------->8-----------------------------
% bzr init test
% cd test
% echo hi >k
% echo bye >g

% b add k g
added k
added g

% b ci -m 'Added k and g.'
added g
added k
Committed revision 1.

% b remove k
% echo moo >>g

% b ci -m "Make g moo, don't commit k's removal yet." g
modified g
deleted k
Committed revision 2.
-----------------------------8<-----------------------------

In the last step, I would not expect for "deleted k" to be commited.

--
Adeodato Simó dato at net.com.org.es
Debian Developer adeodato at debian.org

                     Listening to: Angelo Badalamenti - Mulholland Drive

[Martin Pool (mbp)]

Thanks for the report - yes, I agree it's confusing and we should fix it.

(See also the recent remove/rm/forget/etc thread.)

--
Martin

[Aaron Bentley (abentley)]

This bug is actually unrelated to the 'implicit delete' question, because it only occurs with files that have been 'removed' explicitly.