encrypt_header is left enabled when creating zip archives

[lavinog]

Binary package hint: file-roller

Steps to recreate:
Right click a file to bring up the compression dialog.
Select the 7z format.
Under other options: enter a password, and check "Encrypt the file list too"
Click create.

Compress another file in the zip format, and enter a password.
"Encrypt the file list too" will be checked, but greyed out.
Clicking create will generate the following error.
---------------------------
7-Zip 9.04 beta Copyright (c) 1999-2009 Igor Pavlov 2009-05-30
p7zip Version 9.04 (locale=en_US.UTF-8,Utf16=on,HugeFiles=on,2 CPUs)
Scanning

Creating archive /home/greg/Desktop/f143963072.jpg.zip

System error:
E_INVALIDARG
---------------------------
This is the same error received when using 7z with -tzip -mhe=on
mhe=on can only be used with the 7z format.

A quick way to uncheck it is to use:
gconftool-2 --type bool --set /apps/file-roller/general/encrypt_header false

$lsb_release -rd
Description: Ubuntu 9.10
Release: 9.10

$apt-cache policy file-roller
file-roller:
  Installed: 2.28.1-0ubuntu1
  Candidate: 2.28.1-0ubuntu1
  Version table:
 *** 2.28.1-0ubuntu1 0
        500 http://us.archive.ubuntu.com karmic/main Packages
        100 /var/lib/dpkg/status

[lavinog (lavinog)]

One possible solution:
fr-command-7z.c:
Original:
--------------
if (is_mime_type (comm->mime_type, "application/zip"))
  fr_process_add_arg (comm->process, "-tzip");

 fr_process_add_arg (comm->process, "-bd");
 fr_process_add_arg (comm->process, "-y");
 fr_process_add_arg (comm->process, "-l");
 add_password_arg (comm, comm->password, FALSE);
 if ((comm->password != NULL) && (*comm->password != 0) && comm->encrypt_header)
  fr_process_add_arg (comm->process, "-mhe=on");
--------------

Change:
--------------
 fr_process_add_arg (comm->process, "-bd");
 fr_process_add_arg (comm->process, "-y");
 fr_process_add_arg (comm->process, "-l");
 add_password_arg (comm, comm->password, FALSE);

if (is_mime_type (comm->mime_type, "application/zip"))
  fr_process_add_arg (comm->process, "-tzip");
else
 if ((comm->password != NULL) && (*comm->password != 0) && comm->encrypt_header)
  fr_process_add_arg (comm->process, "-mhe=on");
--------------

[Pedro Villavicencio (pedro)]

Thank you for your bug report. This bug has been reported to the developers of the software. You can track it and make comments at:
 https://bugzilla.gnome.org/show_bug.cgi?id=600131

[Pedro Villavicencio (pedro)]

this has been fixed upstream (wow that was fast) thanks a lot for reporting!.

[Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount)]

This should be fixed in Ubuntu 9.10. Thanks for reporting.

[Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount)]

Sorry, I meant Ubuntu 10.04.