MPS few bugs

[Grzegorz Grzelak (OpenGLOBE.pl)]

It is further investigation after fix for bug #448626 and some discussion with Jay and vra in Answer section.

1. When you click "Procure incoming left" system creates Procurement with reservation (confirmed stock move) from Stock to Output. Which is absolutely wrong. It should create Procurement from Supplier or Production to Stock (Warehouse Input location indeed). In Answer section we discussed if this procurement should be dependant of current stock quantity and my opinion is that MPS is a tool for creating procurement unconditionally like for "make to order" method. Current stock quantity shouldn't have any influence to that because it is planning for future according to simulation.

2. When you create database with "Packing List & Delivery Order" option in "Steps to Deliver a Sale Order" you cannot see the quantities in "Confirmed Out". There are 0. I cannot understand it. I have created Confirmed Sales Order. And I see moves: Stock to Output - Confirmed and Output to Customers - Waiting. They are not taken into account in calculation of MPS.

3. I noticed (vra has confirmed) that when you calculate current period Stock quantity is not simulated. It is always current real stock. I don't see any reason for that. Logistic Manager should be able to work with MPS in current period to adjust something and should be able to see stock simulation.

4. Please change the field label "Stock" in form and list view to "Stock Simulation" or something like that.

5. Please change the label "Expected In" to "Incoming Left". It will fit to button name "Procure Incoming Left". I know that "Expected In" is analogy to "Expected Out" but OUT moves are really "expected". IN moves are not "expected". They have to be created. This change will make selfexplanation of MPS.

6. Please change the field order in form to:
Left column
Period
Warehouse
Planned Sales
Planned Out
Confirmed Out
Expected Out

Right column:
Product
UOM
Planned In
Confirmed In
Incoming Left
Stock Simulation

Current order is to mixed.
In list view change column order to:
Planned Sales, Planned Out, Confirmed Out, Expected Out, Planned In, Confirmed In, Incoming left, Stock Simulation.

I also think that calculation of MPS for few periods ahead is unusable which is also almost a bug but I described it in Blueprint:
https://blueprints.launchpad.net/openobject-addons/+spec/stock-planning-ergonomy-and-power
I hope someone read it before 5.2 or 6.0.

[Grzegorz Grzelak (OpenGLOBE.pl) (grzegorz-og.pl)]

Another bug found:

Let me have 2 Warehouses. It is impossible to make sales forecast per Warehouse at all. When I try to use MPS Confirmed In and Confirmed Out works. When I change warehouse I see that MPS takes into account only confirmed moves for this chosen warehouse. But Stock quantity is not counted by Warehouse but for whole company. So when you have two Sales warehouses MPS is unusable.

[Olivier Dony (Odoo) (odo-openerp)]

Have a look at revision 4128 in extra-5.0 , it fixes the biggest problem: the procurement order and the stock locations used + a few cosmetics to improve labels and useability (many things similar to what you suggested).

I'm going to merge it in trunk as well.

Multiple warehouse issue not fixed, but this could be a different bug report.
As for item number 2 in the bug description, the 'Confirmed Out' is simply taken from what product.product.outgoing_qty field returns for the corresponding period. So if there's an issue there it probably isn't specific to stock_planning.

Hope this helps...

[Olivier Dony (Odoo) (odo-openerp)]

Err, make that revision 4180, not 4128, sorry (<email address hidden>)

[Olivier Dony (Odoo) (odo-openerp)]

Merged in trunk by rev 4270 (<email address hidden>)

[Olivier Dony (Odoo) (odo-openerp)]

FYI: Extra-trunk rev 4271 complements 4270 by fixing the menu positioning to match the new menu layout in 5.2.

[Grzegorz Grzelak (OpenGLOBE.pl) (grzegorz-og.pl)]

Hello Olivier,

I hope you didn't spend too much time on this because I am working on this module (stock_planning) as my first real contribution. I have fixed a lot of bugs and made improvements at least described in:
https://blueprints.launchpad.net/openobject-addons/+spec/stock-planning-ergonomy-and-power
I have been involved in logistic projects and I think I know how such module should work. I am working on it from beginning of december. I hope I finish it at the end of january. I am not commiter so I cannot work on extra-trunk branch.

But I don't want to make separate module improving this one. I think improving current module and replace old one will be more consistent. New module is targeted for 5.2 as it will use multicompany.

According to above can I ask for expert help for further work? Can you track my progress?

I have following questions:
1. Should I create new branch for this module and when I finish ask for merging into extra-trunk with remark that module should replace current? My work is not published yet.

2. Haw can I narrow the warehouse selection according to company? I have a field company and I want that when company is selected Warehouse selection is narrowed to this company warehouses. I use widget="selection" for company and warehouse selection. I see that it is not done in fe. Sales order and user can choose company and shop outside this company. This problem has to solved somehow generally.

3. I have made very solid documentation 100 text lines and a lot of field helps. Should I place the documentation in description in terp.py?

4. Where can I ask for english language correction by english native speakers? In launchpad or in web forums.

5. I will use your fixed revision for further developing as you wrote about new menu standards. But how can I work on this module to cooperate with other UI or other standard changes?

6. Where can we continue developing discussion on this module? Can we use this bug thread for it?

Regards
Grzegorz

[Olivier Dony (Odoo) (odo-openerp)]

Hi Grzegorz,

0. Don't worry about the quick fix, the point was to have a basic working version of the module, it took a few minutes only.
You're right, improving the existing module is much better than making a separate one in this case.

1. Yes, definitely. Either create a branch of openobject-addons/trunk in your own launchpad area or in any group you are member of (now you're in openerp-commiter too :-)). Then you can attach the new branch to this bug and to your blueprint, if not done yet.

2. The correct way to do this is using ir.rule + ir.rule.group, preventing people to access multicompany-aware objects if they do not meet the multi-company criterions. Basically an ir.rule is like a global domain filter. Have a look at addons in trunk to see how it works (for example in account/security/account_security.xml)

3. You can put it in the terp as a starting point, but you could also add it in the online documentation. Have a look at http://launchpad.net/openobject-doc. You could create a branch of that one too and add your documentation in RST format somewhere down into source/book.

4. Both, after pushing your branch on launchpad. See also http://openobject.com/wiki/index.php/English_Improvements and the linked forum thread if you're looking for advice.

5. If you're targetting trunk/5.2 you should indeed branch off trunk after my fix. You will need to track trunk to keep up with other important changes that will still occur. Most changes should be transparent to you though.

[Olivier Dony (Odoo) (odo-openerp)]

... hmm, forgot 6. ...

6. This bug is appropriate, or your blueprint. I'll just have to properly filter my mailbox to monitor this ;-)

[Grzegorz Grzelak (OpenGLOBE.pl) (grzegorz-og.pl)]

Hello Olivier:
Quite late but my work yet now can be published.
You can see my work in branch
lp:~grzechu.g/openobject-addons/x_trunk_stock_planning_new
I will make some announcement for testing and language correction.

My question:
1. Should I somehow indicate that my module is not suitable for stable 5.0.6? It contains company_id references so it will work just in trunk (5.2). It looks that branch comes from trunk so it will be merged back to trunk. I simply don't understand how some fixes goes to stable. I have made another branch for polish account chart and I wander how it should go to trunk and stable.

2. In module description I have changed version to 1.1 and author to "Tiny and Grzegorz Grzelak (Cirrus)" would it be OK?

3. In description I have added long user guide text. Is it proper place for it (probably not)? Do we have place for help text for whole form view like for field with "help= "?

My suggestion:
Maybe someone can take a look at my UoM solution. UoM and UoS in one field with domain not allowing user to choose UoM out of UoM or UoS category and with feature of recalculation between any UoM and UoS units. Anyway it needs improvement to see package and palette units.

Description of my improvement (branch text):
Total improvement of Master Procurement Scheduler:

it contains 6 elements (menu)

1. Periods creation - a little change that periods are form 00:00:00 till 23:59:00 (instead of from 00:00:00 till 00:00:00 next day)

2. Periods tree and form view - No changes

3. Forecasts creation - New feature for quick creation of many forecasts lines.

4. Forecast tree and form
- Tree: new 5.2 style search bar.
- Form: Added Sales history grid for user, department, warehouse or company per selected periods.

5. Planning creation - New feature for quick creation of many planning lines.

6. Planning tree and form
- Tree: new 5.2 style search bar.
- Form: New concept of calculation for Stock Simulation allowing to make planning few periods ahead. Forecast and OrderPoint indicators. Procurement creation fixed. Added internal pick list move from another warehouse. Requisition trace.

General:
UoM recalculation fixed - New concept of default and secondary UoM in one field.

[Grzegorz Grzelak (OpenGLOBE.pl) (grzegorz-og.pl)]

Ah, another question:

In the meantime the POT file was created for module before my changes. Should I create POT file for my improvement (new texts) or it will be made automatically?

[Grzegorz Grzelak (OpenGLOBE.pl) (grzegorz-og.pl)]

Current status of my branch is that my module stock_planning marked as mature was taken to trunk-addons6.0 branch by OpenERP guys. So I stopped to work and I don't know what to do next with it. Generally functionality is finished and I am happy the module is appreciated. So I should close the bug and blueprint. But old stock_planning module is still in trunk-extra branch (as second module of the same name). I will close bug and BP when I see the old module is deleted from trunk-extra.

Thank you