Local album covers detection is case-sensitive
Bug #462512 reported by
Olivier Tilloy
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Moovida |
Fix Released
|
Low
|
Peter |
Bug Description
Steps to reproduce:
1) Have two music albums in two separate directories, each containing the album's cover as an image file:
* album 1: "cover.jpg"
* album 2: "Cover.jpg"
2) Start Moovida, add those directories to the music library
3) Go to MUSIC / Library
Expected result: the local covers show for the two albums.
Current result: the local cover show only for album 1. The cover for album either doesn't show at all or is downloaded from last.fm.
The covers' filenames detection should be made case-insensitive (both on the filename and on the extension) so that Moovida equally finds "cover.jpg", "Cover.jpg", "COVER.JPG", "cOvEr.JpG", and so forth.
Related branches
Changed in elisa: | |
importance: | Undecided → Medium |
status: | New → Confirmed |
Changed in moovida: | |
assignee: | nobody → Kaleo (fboucault) |
milestone: | none → bug-fixing-day |
status: | Confirmed → In Progress |
Changed in moovida: | |
milestone: | none → bug-fixing-day |
assignee: | nobody → Peter (j-launchpad-maubp-freeserve-co-uk) |
status: | Confirmed → Fix Committed |
Changed in moovida: | |
milestone: | bug-fixing-day → 1.0.9 |
Changed in moovida: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Redoes the local cover art search, use os.listdir() rather than trying os.path.isfile() for all possible filenames which is not practical once we consider mixed cases. Keeps the check for is a file and the correct access requirements. Note this preserves the existing priorities (the order recorded in the preferences).
Also note that I was seeing iterate_candidates sometimes called with None as the track_path, so I added a check for this.
Developed and test on Linux with Python 2.6