supermirror branch scanner should record last scanned timestamp

Bug #45987 reported by David Allouche
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
James Henstridge

Bug Description

The branch scanner should record the time it last processed a branch as Branch.last_scanned.

This would enable two things:

* fix the silly "this branch was not scanned yet, or no revision were found on the last scan" message on the branch page.
* optimise the branch scanner to only process branches whose last_scanned < last_mirrored.

Tags: lp-code
Revision history for this message
David Allouche (ddaa) wrote :

The Branch.status_updated timestamp should probably be renamed to last_scanned.

Changed in launchpad-bazaar:
status: Unconfirmed → Confirmed
David Allouche (ddaa)
Changed in launchpad-bazaar:
assignee: nobody → jamesh
Revision history for this message
James Henstridge (jamesh) wrote :

On IRC, Robert suggested storing the last scanned revision ID. This may be more useful in debugging problems with the scanning.

Recording the last scan timestamp is probably a good idea still, since it might be more meaningful to users.

As far as the "last_scanned < last_mirrored" optimisation, it might be worth using revision IDs here and only scan if last_scanned_id != last_mirrored_id. This would require branch puller changes though.

Changed in launchpad-bazaar:
status: Confirmed → In Progress
Changed in launchpad-bazaar:
status: In Progress → Fix Committed
Revision history for this message
James Henstridge (jamesh) wrote :

There was a problem with the fix for this bug that was not caught by the test suite. The bug and the problem with the test suite have been fixed in rocketfuel. I'll close the bug when the patch gets cherrypicked or a new rollout happens.

David Allouche (ddaa)
Changed in launchpad-bazaar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.