Show source entries with tokens in private PPAs instead of ppa:team/ppa-name

[Martin Albisetti]

We currently expose the standard link and text to add private PPA's to your sources.list, but it doesn't work unless the users subscription has already been activated. If the users subscription has not been activated we show ppa:team/ppa-name.

If the subscription has been activated we show the right thing (but possibly for the wrong series, see the other p3a bugs for that).

If this was fixed, it would make /+archivesubscriptions/XXX page obsolete

One way to fix it would be to generate the token just-in-time.

[Scott Ritchie (scottritchie)]

This seems like it should be an easy fix, as we already generate the correct text when I click the "view private ppas"-->"view" button under my profile page.

[Julian Edwards (julian-edwards)]

> One way to fix it would be to generate the token just-in-time.

Please don't do that. The idea of tokens is that you can see who is
actually interested in the PPA by forcing them to click through to get
one. We should put an AJAXY button in there that generates a token and
shows it in-place.

[Robert Collins (lifeless)]

On Tue, Jan 10, 2012 at 9:40 PM, Julian Edwards
<email address hidden> wrote:
>> One way to fix it would be to generate the token just-in-time.
>
> Please don't do that. The idea of tokens is that you can see who is
> actually interested in the PPA by forcing them to click through to get
> one.  We should put an AJAXY button in there that generates a token and
> shows it in-place.

I get that idea, but someone visiting the page is indicating interest,
aren't they?

[Julian Edwards (julian-edwards)]

That's up for debate I think. They may visit but then decline to actually download anything once they've viewed the page.

[Robert Collins (lifeless)]

On Wed, Jan 11, 2012 at 10:23 AM, Julian Edwards
<email address hidden> wrote:
> That's up for debate I think. They may visit but then decline to
> actually download anything once they've viewed the page.

Agreed. Of course, that applies to the situation after they have a key
generated too. We really want to see that they get all the way through
to installing a package, I guess.