LauncherEditorDialog - can't output new file

[Michal Hruby]

As the merge is closed, I'll report here:
>> + if (this._output.exists () && !this._output.is_writable ())

> Not needed, and gives an unintended side effect. What if the output path is /root/foo and the user is not a superuser?

If we want to create new desktop file (by passing newly created instance of VFSFile as 2nd parameter of LauncherEditorDialog constructor), lda just displays the "Save as" dialog, bothering the user, who will save it to incorrect location anyway.

[Mark Lee (malept)]

Fix committed in revision 380.
The algorithm is now:
if output file exists {
    if output file is not writable, show "Save As" dialog
} else {
    if parent folder is not writable, show "Save As" dialog
}