TheTVDB plugin doesn't respect mirrors, cause failure to get some images

Bug #458050 reported by Ugo Riboni
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Moovida
Fix Released
High
Ugo Riboni

Bug Description

In the TheTVDB XML API it's clearly specified that we should first retrieve a list of mirrors and then choose one of these mirrors and use it for all further interaction with TheTVDB (see http://thetvdb.com/wiki/index.php?title=Programmers_API , point 1 in "Initial Database Processing" section).

Our TheTVDB plugin doesn't do this, but intead it uses an hardcoded URL (currently "images.thetvdb.com").

This is wrong first because we should respect the API documented on the site, and second because this is actually causing the plugin to fail retrieving some of the images.

For example, we're trying to retrieve the images for show "30 Rock" from http://images.thetvdb.com/banners/seasons/79488-4.jpg but they are actually at http://thetvdb.com/banners/seasons/79488-4.jpg

We can fix this in 2 ways: either by just hardcoding the right mirror (they have only one in their mirrors file anyway), or by actually reading the mirror list from the API.
If we go this second route, we can either retrieve the list at moovida startup, or at the first usage of the plugin for each session, or at the first usage once every N days (and obviously caching the mirror list and last retrieval date in the config file)

Related branches

Olivier Tilloy (osomon)
Changed in elisa:
importance: Undecided → High
milestone: none → bug-fixing-day
status: New → Confirmed
Revision history for this message
Ugo Riboni (uriboni) wrote :

All the images were taken off of the images.thetvtb.com and moved to thetvdb.com
This is explained in http://forums.thetvdb.com/viewtopic.php?f=4&t=2161 and means that they can move it again whenever they want. The only way to be sure we get the right server is to use the mirror system as documented.

Planning to fix this in 2 steps. First hardcode tvdb.com as server, as a stopgap measure. Then implement the proper fix using the mirrors system.

Ugo Riboni (uriboni)
Changed in moovida:
status: Confirmed → In Progress
assignee: nobody → Ugo Riboni (uriboni)
Ugo Riboni (uriboni)
Changed in moovida:
status: In Progress → Fix Committed
Revision history for this message
Olivier Tilloy (osomon) wrote :

Fix released with version 0.5.1 of the plugin published in the plugin repository.

Changed in moovida:
milestone: bug-fixing-day → 1.0.9
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.