+ubuntupkg can create duplicate packaging links
Bug #456430 reported by
Curtis Hovey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Curtis Hovey | ||
Bug Description
The view does not verify that the distroseries + sourcepackage is not already used. The user is either making a mistake, or the user needs to correct the mistake before the link can be made. This code is embedded into the ProductSeriesView. We want this to be a LaunchpadFormView, and it probably should extend +addpackage view to ensure the rules are correct. There are two key differences that this +ubuntupkg does differently than +addpackage. It restricting the distroseries to the Ubuntu focus of development, and it records the change in the history.
Related branches
lp:~sinzui/launchpad/package-link-validation-2
- Edwin Grubbs (community): Approve (code)
-
Diff: 712 lines8 files modifiedlib/lp/bugs/stories/guided-filebug/xx-project-guided-filebug.txt (+1/-1)
lib/lp/registry/browser/configure.zcml (+1/-1)
lib/lp/registry/browser/packaging.py (+8/-5)
lib/lp/registry/browser/productseries.py (+57/-81)
lib/lp/registry/browser/tests/productseries-views.txt (+132/-0)
lib/lp/registry/stories/distribution/xx-distributionsourcepackage-packaging.txt (+0/-45)
lib/lp/registry/stories/packaging/xx-ubuntu-pkging.txt (+0/-136)
lib/lp/registry/templates/productseries-ubuntupkg.pt (+41/-46)
Revision history for this message
| Curtis Hovey (sinzui) wrote | #1 |
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Released |
| status: | Fix Released → Fix Committed |
Revision history for this message
| Curtis Hovey (sinzui) wrote Bug 456430 Fix released | #2 |
| Changed in launchpad-registry: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in launchpad devel r9752.